Fix style in tools/auto_bisect.

tools/auto_bisect/bisect_perf_regression_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import shutil
 import sys
 import unittest
 
@@ skipping 52 matching lines @@
     [[29.547], [29.713], [29.835], [30.132], [30.132], [30.33], [30.406],
      [30.592], [30.72], [34.486], [35.247], [35.253], [35.335], [35.378],
      [35.934], [36.233], [36.41], [36.947], [37.982]]
 ]
 
 # Regression confidence > 95%, taken from: crbug.com/434318
 # Specifically from Builder android_nexus10_perf_bisect Build #1198
 MULTIPLE_VALUES = [
     [
         [18.916, 22.371, 8.527, 5.877, 5.407, 9.476, 8.100, 5.334,
-        4.507, 4.842, 8.485, 8.308, 27.490, 4.560, 4.804, 23.068, 17.577,
-        17.346, 26.738, 60.330, 32.307, 5.468, 27.803, 27.373, 17.823,
-        5.158, 27.439, 5.236, 11.413],
+         4.507, 4.842, 8.485, 8.308, 27.490, 4.560, 4.804, 23.068, 17.577,
+         17.346, 26.738, 60.330, 32.307, 5.468, 27.803, 27.373, 17.823,
+         5.158, 27.439, 5.236, 11.413],
         [18.999, 22.642, 8.158, 5.995, 5.495, 9.499, 8.092, 5.324,
-        4.468, 4.788, 8.248, 7.853, 27.533, 4.410, 4.622, 22.341, 22.313,
-        17.072, 26.731, 57.513, 33.001, 5.500, 28.297, 27.277, 26.462,
-        5.009, 27.361, 5.130, 10.955]
+         4.468, 4.788, 8.248, 7.853, 27.533, 4.410, 4.622, 22.341, 22.313,
+         17.072, 26.731, 57.513, 33.001, 5.500, 28.297, 27.277, 26.462,
+         5.009, 27.361, 5.130, 10.955]
     ],
     [
         [18.238, 22.365, 8.555, 5.939, 5.437, 9.463, 7.047, 5.345, 4.517,
-        4.796, 8.593, 7.901, 27.499, 4.378, 5.040, 4.904, 4.816, 4.828,
-        4.853, 57.363, 34.184, 5.482, 28.190, 27.290, 26.694, 5.099,
-        4.905, 5.290, 4.813],
+         4.796, 8.593, 7.901, 27.499, 4.378, 5.040, 4.904, 4.816, 4.828,
+         4.853, 57.363, 34.184, 5.482, 28.190, 27.290, 26.694, 5.099,
+         4.905, 5.290, 4.813],
         [18.301, 22.522, 8.035, 6.021, 5.565, 9.037, 6.998, 5.321, 4.485,
-        4.768, 8.397, 7.865, 27.636, 4.640, 5.015, 4.962, 4.933, 4.977,
-        4.961, 60.648, 34.593, 5.538, 28.454, 27.297, 26.490, 5.099, 5,
-        5.247, 4.945],
+         4.768, 8.397, 7.865, 27.636, 4.640, 5.015, 4.962, 4.933, 4.977,
+         4.961, 60.648, 34.593, 5.538, 28.454, 27.297, 26.490, 5.099, 5,
+         5.247, 4.945],
         [18.907, 23.368, 8.100, 6.169, 5.621, 9.971, 8.161, 5.331, 4.513,
-        4.837, 8.255, 7.852, 26.209, 4.388, 5.045, 5.029, 5.032, 4.946,
-        4.973, 60.334, 33.377, 5.499, 28.275, 27.550, 26.103, 5.108,
-        4.951, 5.285, 4.910],
+         4.837, 8.255, 7.852, 26.209, 4.388, 5.045, 5.029, 5.032, 4.946,
+         4.973, 60.334, 33.377, 5.499, 28.275, 27.550, 26.103, 5.108,
+         4.951, 5.285, 4.910],
         [18.715, 23.748, 8.128, 6.148, 5.691, 9.361, 8.106, 5.334, 4.528,
-        4.965, 8.261, 7.851, 27.282, 4.391, 4.949, 4.981, 4.964, 4.935,
-        4.933, 60.231, 33.361, 5.489, 28.106, 27.457, 26.648, 5.108,
-        4.963, 5.272, 4.954]
+         4.965, 8.261, 7.851, 27.282, 4.391, 4.949, 4.981, 4.964, 4.935,
+         4.933, 60.231, 33.361, 5.489, 28.106, 27.457, 26.648, 5.108,
+         4.963, 5.272, 4.954]
     ]
 ]
 
 # Default options for the dry run
 DEFAULT_OPTIONS = {
     'debug_ignore_build': True,
     'debug_ignore_sync': True,
     'debug_ignore_perf_test': True,
     'debug_ignore_regression_confidence': True,
     'command': 'fake_command',
     'metric': 'fake/metric',
     'good_revision': 280000,
     'bad_revision': 280005,
 }
 
 # This global is a placeholder for a generator to be defined by the test cases
 # that use _MockRunTests.
 _MockResultsGenerator = (x for x in [])
 
 
-def _MockRunTests(*args, **kwargs):
-  _, _ = args, kwargs
+def _MockRunTests(*args, **kwargs):  # pylint: disable=unused-argument
   return _FakeTestResult(_MockResultsGenerator.next())
 
 
 def _FakeTestResult(values):
   result_dict = {'mean': 0.0, 'std_err': 0.0, 'std_dev': 0.0, 'values': values}
   success_code = 0
   return (result_dict, success_code)
 
 
 def _GetBisectPerformanceMetricsInstance(options_dict):
@@ skipping 242 matching lines @@
 
   def _CheckAbortsEarly(self, results):
     """Returns True if the bisect job would abort early."""
     global _MockResultsGenerator
     _MockResultsGenerator = (r for r in results)
     bisect_class = bisect_perf_regression.BisectPerformanceMetrics
     original_run_tests = bisect_class.RunPerformanceTestAndParseResults
     bisect_class.RunPerformanceTestAndParseResults = _MockRunTests
 
     try:
-      _GenericDryRun(_GetExtendedOptions(0, 0, False))
+      dry_run_results = _GenericDryRun(_GetExtendedOptions(0, 0, False))
     except StopIteration:
       # If StopIteration was raised, that means that the next value after
       # the first two values was requested, so the job was not aborted.
       return False
     finally:
       bisect_class.RunPerformanceTestAndParseResults = original_run_tests
 
     # If the job was aborted, there should be a warning about it.
-    assert [w for w in results.warnings
+    assert [w for w in dry_run_results.warnings
             if 'could not reproduce the regression' in w]
     return True
 
-  def testBisectStopsOnClearUnclearRegression(self):
+  def testBisectAbortedOnClearNonRegression(self):
     self.assertTrue(self._CheckAbortsEarly(CLEAR_NON_REGRESSION))
 
-  def testBisectStopsOnClearUnclearRegression(self):
+  def testBisectNotAborted_AlmostRegression(self):
     self.assertFalse(self._CheckAbortsEarly(ALMOST_REGRESSION))
 
-  def testBisectStopsOnClearUnclearRegression(self):
+  def testBisectNotAborted_ClearRegression(self):
     self.assertFalse(self._CheckAbortsEarly(CLEAR_REGRESSION))
 
-  def testBisectStopsOnClearUnclearRegression(self):
+  def testBisectNotAborted_BarelyRegression(self):
     self.assertFalse(self._CheckAbortsEarly(BARELY_REGRESSION))
 
-  def testBisectStopsOnClearUnclearRegression(self):
+  def testBisectNotAborted_MultipleValues(self):
     self.assertFalse(self._CheckAbortsEarly(MULTIPLE_VALUES))
 
   def testGetCommitPosition(self):
     cp_git_rev = '7017a81991de983e12ab50dfc071c70e06979531'
     self.assertEqual(291765, source_control.GetCommitPosition(cp_git_rev))
 
     svn_git_rev = 'e6db23a037cad47299a94b155b95eebd1ee61a58'
     self.assertEqual(291467, source_control.GetCommitPosition(svn_git_rev))
 
   def testGetCommitPositionForV8(self):
@@ skipping 42 matching lines @@
     mock_RunGClient.return_value = 0
     bisect_instance._SyncRevision(
         'chromium', 'e6db23a037cad47299a94b155b95eebd1ee61a58', 'gclient')
     expected_params = [
         'sync',
         '--verbose',
         '--nohooks',
         '--force',
         '--delete_unversioned_trees',
         '--revision',
-        'src@e6db23a037cad47299a94b155b95eebd1ee61a58'
-        ]
+        'src@e6db23a037cad47299a94b155b95eebd1ee61a58',
+    ]
 
     mock_RunGClient.assert_called_with(expected_params, cwd=None)
 
   @mock.patch('bisect_utils.RunGit')
   def testSyncToRevisionForWebKit(self, mock_RunGit):
     bisect_instance = _GetBisectPerformanceMetricsInstance(DEFAULT_OPTIONS)
     mock_RunGit.return_value = None, None
     bisect_instance._SyncRevision(
-        'webkit', 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61' , None)
+        'webkit', 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61', None)
     expected_params = ['checkout', 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61']
     mock_RunGit.assert_called_with(expected_params)
 
   def testTryJobSvnRepo_PerfBuilderType_ReturnsRepoUrl(self):
-    self.assertEqual(bisect_perf_regression.PERF_SVN_REPO_URL,
+    self.assertEqual(
+        bisect_perf_regression.PERF_SVN_REPO_URL,
         bisect_perf_regression._TryJobSvnRepo(fetch_build.PERF_BUILDER))
 
   def testTryJobSvnRepo_FullBuilderType_ReturnsRepoUrl(self):
-    self.assertEqual(bisect_perf_regression.FULL_SVN_REPO_URL,
+    self.assertEqual(
+        bisect_perf_regression.FULL_SVN_REPO_URL,
         bisect_perf_regression._TryJobSvnRepo(fetch_build.FULL_BUILDER))
 
   def testTryJobSvnRepo_WithUnknownBuilderType_ThrowsError(self):
     with self.assertRaises(NotImplementedError):
       bisect_perf_regression._TryJobSvnRepo('foo')
 
   def _CheckIsDownloadable(self, depot, target_platform='chromium',
                            builder_type='perf'):
     opts = dict(DEFAULT_OPTIONS)
     opts.update({'target_platform': target_platform,
@@ skipping 165 matching lines @@
         (['update-index', '--refresh', '-q'], (None, 0)),
         (['diff-index', 'HEAD'], (None, 0)),
         (['checkout', '-b', new_branch], ('None', 0)),
         (['branch', '--set-upstream-to', parent_branch],
          ('Setuptream fails', 0)),
         (['try',
           '--bot=%s' % bot_name,
           '--revision=%s' % git_revision,
           '--name=%s' % bisect_job_name,
           '--svn_repo=%s' % bisect_perf_regression.PERF_SVN_REPO_URL,
-          '--diff=%s' % patch_content
-         ], (None, 1)),
+          '--diff=%s' % patch_content],
+         (None, 1)),
     ]
     self._AssertRunGitExceptions(
         try_cmd, bisect_perf_regression._StartBuilderTryJob,
         fetch_build.PERF_BUILDER, git_revision, bot_name, bisect_job_name,
         patch)
 
   def testBuilderTryJob(self):
     git_revision = 'ac4a9f31fe2610bd146857bbd55d7a260003a888'
     bot_name = 'linux_perf_bisect_builder'
     bisect_job_name = 'testBisectJobname'
     patch = None
     patch_content = '/dev/null'
     new_branch = bisect_perf_regression.BISECT_TRYJOB_BRANCH
     parent_branch = bisect_perf_regression.BISECT_MASTER_BRANCH
     try_cmd = [
         (['rev-parse', '--abbrev-ref', 'HEAD'], (parent_branch, 0)),
         (['branch', '--list'], ('bisect-tryjob\n*master\nsomebranch', 0)),
         (['branch', '-D', new_branch], ('None', 0)),
         (['update-index', '--refresh', '-q'], (None, 0)),
         (['diff-index', 'HEAD'], (None, 0)),
         (['checkout', '-b', new_branch], ('None', 0)),
         (['branch', '--set-upstream-to', parent_branch],
          ('Setuptream fails', 0)),
         (['try',
           '--bot=%s' % bot_name,
           '--revision=%s' % git_revision,
           '--name=%s' % bisect_job_name,
           '--svn_repo=%s' % bisect_perf_regression.PERF_SVN_REPO_URL,
-          '--diff=%s' % patch_content
-         ], (None, 0)),
+          '--diff=%s' % patch_content],
+         (None, 0)),
     ]
     self._SetupRunGitMock(try_cmd)
     bisect_perf_regression._StartBuilderTryJob(
         fetch_build.PERF_BUILDER, git_revision, bot_name, bisect_job_name,
         patch)
 
 
 if __name__ == '__main__':
   unittest.main()