Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: runtime/vm/code_patcher.cc

Issue 100103011: Changes to support dprof and Observatory profiler UIs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_patcher.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher.cc
diff --git a/runtime/vm/code_patcher.cc b/runtime/vm/code_patcher.cc
index 6fda035f4047783368cc8dffa9e299c6d09d6b20..283a70648aa060810f30a534ab01490d058af6d0 100644
--- a/runtime/vm/code_patcher.cc
+++ b/runtime/vm/code_patcher.cc
@@ -65,12 +65,23 @@ void CodePatcher::RestoreEntry(const Code& code) {
}
+bool CodePatcher::IsEntryPatched(const Code& code) {
+ const uword patch_addr = code.GetPcForDeoptId(Isolate::kNoDeoptId,
+ PcDescriptors::kEntryPatch);
+ if (patch_addr == 0) {
+ return false;
+ }
+ JumpPattern jmp_entry(patch_addr, code);
+ return jmp_entry.IsValid();
+}
+
+
bool CodePatcher::CodeIsPatchable(const Code& code) {
const uword patch_addr = code.GetPcForDeoptId(Isolate::kNoDeoptId,
PcDescriptors::kEntryPatch);
// kEntryPatch may not exist which means the function is not patchable.
if (patch_addr == 0) {
- return true;
+ return false;
}
JumpPattern jmp_entry(patch_addr, code);
if (code.Size() < (jmp_entry.pattern_length_in_bytes() * 2)) {
« no previous file with comments | « runtime/vm/code_patcher.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698