Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: runtime/vm/native_symbol_macos.cc

Issue 100103011: Changes to support dprof and Observatory profiler UIs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/native_symbol_macos.cc
diff --git a/runtime/vm/native_symbol_macos.cc b/runtime/vm/native_symbol_macos.cc
index 4de33cef80b62eb1b3c5cfa9f91a6ee4990fadcc..cc9084742cf137c48909191ee17751dba7bf6484 100644
--- a/runtime/vm/native_symbol_macos.cc
+++ b/runtime/vm/native_symbol_macos.cc
@@ -21,7 +21,7 @@ void NativeSymbolResolver::ShutdownOnce() {
}
-char* NativeSymbolResolver::LookupSymbolName(uintptr_t pc) {
+char* NativeSymbolResolver::LookupSymbolName(uintptr_t pc, uintptr_t* start) {
Dl_info info;
int r = dladdr(reinterpret_cast<void*>(pc), &info);
if (r == 0) {
@@ -30,6 +30,7 @@ char* NativeSymbolResolver::LookupSymbolName(uintptr_t pc) {
if (info.dli_sname == NULL) {
return NULL;
}
+ *start = reinterpret_cast<uintptr_t>(info.dli_saddr);
Ivan Posva 2014/01/03 19:24:54 ditto
Cutch 2014/01/03 19:42:30 Done.
int status;
char* demangled = abi::__cxa_demangle(info.dli_sname, NULL, NULL, &status);
if (status == 0) {

Powered by Google App Engine
This is Rietveld 408576698