Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: runtime/vm/profiler.h

Issue 100103011: Changes to support dprof and Observatory profiler UIs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/profiler.h
diff --git a/runtime/vm/profiler.h b/runtime/vm/profiler.h
index 1e0ab7328c7863a8061017a3ffa99e40fcd2c696..91307ef7219aa12773fd8dcd42f01df8a58c13ea 100644
--- a/runtime/vm/profiler.h
+++ b/runtime/vm/profiler.h
@@ -16,6 +16,7 @@ namespace dart {
// Forward declarations.
class JSONArray;
class JSONStream;
+class ProfilerSymbolHelper;
struct Sample;
// Profiler
@@ -32,8 +33,7 @@ class Profiler : public AllStatic {
static void EndExecution(Isolate* isolate);
static void PrintToJSONStream(Isolate* isolate, JSONStream* stream);
-
- static void WriteTracing(Isolate* isolate);
+ static void WriteSamples(Isolate* isolate);
static SampleBuffer* sample_buffer() {
return sample_buffer_;
@@ -43,8 +43,9 @@ class Profiler : public AllStatic {
static bool initialized_;
static Monitor* monitor_;
- static void WriteTracingSample(Isolate* isolate, intptr_t pid,
- Sample* sample, JSONArray& events);
+ static void WriteSample(Isolate* isolate,
+ ProfilerSymbolHelper* symbol_helper,
+ Sample* sample, JSONArray& events);
static void RecordTickInterruptCallback(const InterruptedThreadState& state,
void* data);
@@ -109,10 +110,10 @@ class SampleBuffer {
Sample* ReserveSample();
- Sample* GetSample(intptr_t i) const {
+ Sample GetSample(intptr_t i) const {
ASSERT(i >= 0);
ASSERT(i < capacity_);
- return &samples_[i];
+ return samples_[i];
}
private:

Powered by Google App Engine
This is Rietveld 408576698