Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 100103008: Remove ENCRYPTED_MEDIA_V2 as it is always set. (Closed)

Created:
7 years ago by lgombos
Modified:
7 years ago
CC:
blink-reviews, jamesr, nessy, arv+blink, Rik, dsinclair, philipj_slow, gasubic, jbroman, watchdog-blink-watchlist_google.com, danakj, feature-media-reviews_chromium.org, dglazkov+blink, pdr., krit, adamk+blink_chromium.org, Stephen Chennney, rwlbuis, vcarbune.chromium, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the ENCRYPTED_MEDIA_V2 guard as it is always set. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163940

Patch Set 1 #

Total comments: 1

Patch Set 2 : Alphabetize headers #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -47 lines) Patch
M Source/build/features.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 2 4 chunks +1 line, -10 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 5 chunks +3 lines, -10 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaKeyError.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.cpp View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyNeededEvent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyNeededEvent.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyNeededEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/media/MediaPlayer.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lgombos
This has been set over 6 month now. Time to remove the guard.
7 years ago (2013-12-14 19:44:09 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/100103008/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/100103008/diff/1/Source/core/html/HTMLMediaElement.cpp#oldcode91 Source/core/html/HTMLMediaElement.cpp:91: #include "modules/encryptedmedia/MediaKeys.h" Please alphabetize these headers with the ...
7 years ago (2013-12-15 06:11:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/100103008/20001
7 years ago (2013-12-16 02:25:49 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLMediaElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-16 02:25:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/100103008/40001
7 years ago (2013-12-16 02:54:27 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-16 04:38:59 UTC) #6
Message was sent while issue was closed.
Change committed as 163940

Powered by Google App Engine
This is Rietveld 408576698