Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100103002: [rAC, OSX] Default to prod wallet. (Closed)

Created:
7 years ago by groby-ooo-7-16
Modified:
7 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAC, OSX] Default to prod wallet. R=estade@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238437

Patch Set 1 #

Patch Set 2 : Fix unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 1 chunk +1 line, -7 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_service_url.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_service_url_unittest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
groby-ooo-7-16
7 years ago (2013-12-02 20:52:24 UTC) #1
Evan Stade
lgtm
7 years ago (2013-12-02 20:55:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/100103002/1
7 years ago (2013-12-02 23:03:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195597
7 years ago (2013-12-02 23:37:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/100103002/20001
7 years ago (2013-12-03 03:09:32 UTC) #5
groby-ooo-7-16
Heads up - removed OSX code in unit tests, too.
7 years ago (2013-12-03 03:09:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195914
7 years ago (2013-12-03 05:52:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/100103002/20001
7 years ago (2013-12-03 18:40:47 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-03 18:42:06 UTC) #9
Message was sent while issue was closed. 
Change committed as 238437

Powered by Google App Engine
This is Rietveld 408576698