Mapping file busy/exists in POSIX File::OSErrorToFileError().

base/files/file_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <unistd.h>
@@ skipping 453 matching lines @@
 }
 
 // Static.
 File::Error File::OSErrorToFileError(int saved_errno) {
   switch (saved_errno) {
     case EACCES:
     case EISDIR:
     case EROFS:
     case EPERM:
       return FILE_ERROR_ACCESS_DENIED;
+    case EBUSY:

[rvargas (doing something else), 2015/03/12 22:10:57]

My guess is that this is also not defined by NaCl.

[cmumford, 2015/03/12 22:41:32]

Looks like EBUSY *is* supported. Lots of matches in native_client_sdk/**.cc. The
PNACL team seems to think it's supported too. ETXTBUSY is not in there (which
agrees with the current implementation), and to be safe I verified that EIO is
supported.

I'm also a little confused why we ETXTBUSY is #ifdef'ed out. Sure NaCL never
set's errno to this value, but if that ever changes then we'll stop mapping the
value. Why not just map it (but have a comment saying it'll probably never be
seen)?

[rvargas (doing something else), 2015/03/12 22:58:07]

My impression is that they wanted to provide a strict subset of functionality
and wanted to make sure the compiler would complain as soon as possible.

I would be happy to see ifdefs disappear but that's another discussion :)

+      return FILE_ERROR_IN_USE;
 #if !defined(OS_NACL)  // ETXTBSY not defined by NaCl.
     case ETXTBSY:

[rvargas (doing something else), 2015/03/12 22:58:07]

nit: Given that this is staying, we should probably write the code as we
normally would and wrap only this line with an ifdef.

       return FILE_ERROR_IN_USE;
 #endif
     case EEXIST:
       return FILE_ERROR_EXISTS;
+    case EIO:
+      return FILE_ERROR_IO;
     case ENOENT:
       return FILE_ERROR_NOT_FOUND;
     case EMFILE:
       return FILE_ERROR_TOO_MANY_OPENED;
     case ENOMEM:
       return FILE_ERROR_NO_MEMORY;
     case ENOSPC:
       return FILE_ERROR_NO_SPACE;
     case ENOTDIR:
       return FILE_ERROR_NOT_A_DIRECTORY;
@@ skipping 50 matching lines @@
 }
 
 void File::SetPlatformFile(PlatformFile file) {
   CHECK(!file_.is_valid());
   file_.reset(file);
   if (file_.is_valid())
     ProtectFileDescriptor(GetPlatformFile());
 }
 
 }  // namespace base