android_webview/native/aw_contents_io_thread_client_impl.h - Issue 1001003004: [Android WebView] Implement a better OnReceivedError callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_io_thread_client_impl.h

Issue 1001003004: [Android WebView] Implement a better OnReceivedError callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed the last comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java ('k') | android_webview/native/aw_contents_io_thread_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents_io_thread_client_impl.h

diff --git a/android_webview/native/aw_contents_io_thread_client_impl.h b/android_webview/native/aw_contents_io_thread_client_impl.h

index 41c7b8aa17a5b8f7572302e2e2a90f5f7bf7b1a8..97ba3146091604596ff47d6a80fdd61ac7726384 100644

--- a/android_webview/native/aw_contents_io_thread_client_impl.h

+++ b/android_webview/native/aw_contents_io_thread_client_impl.h

@@ -48,7 +48,6 @@ class AwContentsIoThreadClientImpl : public AwContentsIoThreadClient {

bool PendingAssociation() const override;

CacheMode GetCacheMode() const override;

scoped_ptr<AwWebResourceResponse> ShouldInterceptRequest(

- const GURL& location,

const net::URLRequest* request) override;

bool ShouldBlockContentUrls() const override;

bool ShouldBlockFileUrls() const override;

@@ -62,6 +61,7 @@ class AwContentsIoThreadClientImpl : public AwContentsIoThreadClient {

void NewLoginRequest(const std::string& realm,

const std::string& account,

const std::string& args) override;

+ void OnReceivedError(const net::URLRequest* request) override;

void OnReceivedHttpError(

const net::URLRequest* request,

const net::HttpResponseHeaders* response_headers) override;