Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2281)

Unified Diff: android_webview/browser/aw_request_interceptor.cc

Issue 1001003004: [Android WebView] Implement a better OnReceivedError callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed the last comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_request_interceptor.cc
diff --git a/android_webview/browser/aw_request_interceptor.cc b/android_webview/browser/aw_request_interceptor.cc
index 381a8ab03cdad3657424de878920657fd72bb17a..45adfb6aa34a36da3a2cfd4c91e5db5d6a22fe53 100644
--- a/android_webview/browser/aw_request_interceptor.cc
+++ b/android_webview/browser/aw_request_interceptor.cc
@@ -36,7 +36,6 @@ AwRequestInterceptor::~AwRequestInterceptor() {
scoped_ptr<AwWebResourceResponse>
AwRequestInterceptor::QueryForAwWebResourceResponse(
- const GURL& location,
net::URLRequest* request) const {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
int render_process_id, render_frame_id;
@@ -50,7 +49,7 @@ AwRequestInterceptor::QueryForAwWebResourceResponse(
if (!io_thread_client.get())
return scoped_ptr<AwWebResourceResponse>();
- return io_thread_client->ShouldInterceptRequest(location, request).Pass();
+ return io_thread_client->ShouldInterceptRequest(request).Pass();
}
net::URLRequestJob* AwRequestInterceptor::MaybeInterceptRequest(
@@ -71,7 +70,7 @@ net::URLRequestJob* AwRequestInterceptor::MaybeInterceptRequest(
new base::SupportsUserData::Data());
scoped_ptr<AwWebResourceResponse> aw_web_resource_response =
- QueryForAwWebResourceResponse(request->url(), request);
+ QueryForAwWebResourceResponse(request);
if (!aw_web_resource_response)
return NULL;

Powered by Google App Engine
This is Rietveld 408576698