Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: android_webview/browser/aw_contents_io_thread_client.h

Issue 1001003004: [Android WebView] Implement a better OnReceivedError callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed the last comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/aw_request_interceptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_contents_io_thread_client.h
diff --git a/android_webview/browser/aw_contents_io_thread_client.h b/android_webview/browser/aw_contents_io_thread_client.h
index 15fddc8b8dcb6a0d566280af0e4ab4adb2ff34de..e24097616d771ba25fc444f5e79941eebffd7811 100644
--- a/android_webview/browser/aw_contents_io_thread_client.h
+++ b/android_webview/browser/aw_contents_io_thread_client.h
@@ -70,7 +70,6 @@ class AwContentsIoThreadClient {
// This method is called on the IO thread only.
virtual scoped_ptr<AwWebResourceResponse> ShouldInterceptRequest(
- const GURL& location,
const net::URLRequest* request) = 0;
// Retrieve the AllowContentAccess setting value of this AwContents.
@@ -104,6 +103,10 @@ class AwContentsIoThreadClient {
const std::string& account,
const std::string& args) = 0;
+ // Called when a resource loading error has occured (e.g. an I/O error,
+ // host name lookup failure etc.)
+ virtual void OnReceivedError(const net::URLRequest* request) = 0;
+
// Called when a response from the server is received with status code >= 400.
virtual void OnReceivedHttpError(
const net::URLRequest* request,
« no previous file with comments | « no previous file | android_webview/browser/aw_request_interceptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698