runtime/observatory/lib/src/elements/class_view.dart - Issue 1000933004: Display ICData entries at call sites, with links to the targets and guarded classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/class_view.dart

Issue 1000933004: Display ICData entries at call sites, with links to the targets and guarded classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: super calls Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/lib/src/elements/class_view.dart

diff --git a/runtime/observatory/lib/src/elements/class_view.dart b/runtime/observatory/lib/src/elements/class_view.dart

index ac49f7ab6c2b607ce424fd64199fbaf2bfc2dcaa..c707f6e861b4517ca6aa4aa5851391d8dcd74e72 100644

--- a/runtime/observatory/lib/src/elements/class_view.dart

+++ b/runtime/observatory/lib/src/elements/class_view.dart

@@ -52,6 +52,7 @@ class ClassViewElement extends ObservatoryElement {

}

void refreshCoverage(var done) {

- cls.refreshCoverage().whenComplete(done);

+ Future.wait([cls.refreshCoverage(),

Cutch 2015/03/17 17:05:04 Can we kill this redundancy?

rmacnak 2015/03/18 19:24:05 Yes, now computing this from the IC data response.

+ cls.refreshCallSiteData()]).whenComplete(done);

}

« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/function_view.dart » ('j') | runtime/vm/coverage.cc » ('J')