Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1000933003: Remove SkLONGLONG. (Closed)

Created:
5 years, 9 months ago by bungeman-skia
Modified:
5 years, 9 months ago
Reviewers:
bsalomon, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkLONGLONG. All users now define SkLONGLONG. This fixes a long outstanding TODO now that int64_t is required. BUG=skia:179 Committed: https://skia.googlesource.com/skia/+/d709ea8d142eba727dda568d0641a4a2c9d09851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -52 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkFixed.h View 2 chunks +5 lines, -13 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/core/SkMath.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
This is, essentially, a rebased version of https://codereview.chromium.org/349663005/ . This depends on https://codereview.chromium.org/1007003005/ landing first ...
5 years, 9 months ago (2015-03-16 19:31:34 UTC) #2
bsalomon
lgtm
5 years, 9 months ago (2015-03-16 19:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000933003/1
5 years, 9 months ago (2015-03-17 14:16:44 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 14:23:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d709ea8d142eba727dda568d0641a4a2c9d09851

Powered by Google App Engine
This is Rietveld 408576698