Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1000933002: sys_info_linux: positive return value of MaxSharedMemorySize for 32-bit build on 64-bit host. (Closed)

Created:
5 years, 9 months ago by Lukasz Jagielski
Modified:
5 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sys_info_linux: positive return value of MaxSharedMemorySize for 32-bit build on 64-bit host. Previous implementation caused DCHECK when value exceeded 32-bit size_t. BUG= Committed: https://crrev.com/e6293f55b0e7abc73ee1925395c5f8b84a9b2e03 Cr-Commit-Position: refs/heads/master@{#325034}

Patch Set 1 #

Patch Set 2 : Changed api to return uint64 #

Patch Set 3 : Removed useless file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M base/sys_info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_freebsd.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/sys_info_linux.cc View 1 4 chunks +5 lines, -7 lines 0 comments Download
M base/sys_info_openbsd.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (5 generated)
Lukasz Jagielski
Hi, PTAL at my CL proposition. Regards, Łukasz
5 years, 9 months ago (2015-03-12 14:51:52 UTC) #2
jamesr
Please ask an OWNER of this code (I'm not one) to review. A list of ...
5 years, 9 months ago (2015-03-12 17:04:57 UTC) #4
Lukasz Jagielski
Hi, Could you PTAL at my CL proposition? Regards, Łukasz
5 years, 9 months ago (2015-03-13 07:37:05 UTC) #6
Mark Mentovai
LGTM, but this function should perhaps return a uint64_t.
5 years, 9 months ago (2015-03-13 11:59:23 UTC) #7
Lukasz Jagielski
Ok, I changed it to uint64 and started some try jobs (wasn't sure which ones ...
5 years, 9 months ago (2015-03-13 12:23:06 UTC) #8
Lukasz Jagielski
On 2015/03/13 12:23:06, Lukasz Jagielski wrote: > Ok, I changed it to uint64 and started ...
5 years, 9 months ago (2015-03-20 15:08:37 UTC) #9
Mark Mentovai
Submitted to the try bots.
5 years, 9 months ago (2015-03-20 16:02:49 UTC) #10
Lukasz Jagielski
On 2015/03/20 16:02:49, Mark Mentovai wrote: > Submitted to the try bots. Is this good ...
5 years, 9 months ago (2015-03-26 13:59:07 UTC) #11
Lukasz Jagielski
On 2015/03/26 13:59:07, Lukasz Jagielski wrote: > On 2015/03/20 16:02:49, Mark Mentovai wrote: > > ...
5 years, 8 months ago (2015-04-14 11:38:03 UTC) #12
Mark Mentovai
I don’t know, the bot logs are no longer available, but this still looks good ...
5 years, 8 months ago (2015-04-14 12:42:50 UTC) #13
Lukasz Jagielski
On 2015/04/14 12:42:50, Mark Mentovai wrote: > I don’t know, the bot logs are no ...
5 years, 8 months ago (2015-04-14 12:47:26 UTC) #14
Lukasz Jagielski
On 2015/04/14 12:42:50, Mark Mentovai wrote: > I don’t know, the bot logs are no ...
5 years, 8 months ago (2015-04-14 12:47:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000933002/40001
5 years, 8 months ago (2015-04-14 12:47:56 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-14 13:45:54 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 13:46:59 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e6293f55b0e7abc73ee1925395c5f8b84a9b2e03
Cr-Commit-Position: refs/heads/master@{#325034}

Powered by Google App Engine
This is Rietveld 408576698