Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1000913004: Fix line info for multi-line strings (issue 22794) (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson
Modified:
5 years, 9 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix line info for multi-line strings (issue 22794) R=pquitslund@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -80 lines) Patch
M pkg/analyzer/lib/src/generated/scanner.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 13 chunks +90 lines, -79 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 9 months ago (2015-03-13 20:22:04 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-13 21:24:26 UTC) #3
pquitslund
LGTM! And thanks. Looking forward to deleting my hackish work-around. :)
5 years, 9 months ago (2015-03-13 21:30:53 UTC) #4
Brian Wilkerson
5 years, 9 months ago (2015-03-13 21:54:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698