Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1000893003: Incorrect handling of HTransitionElementsKind in hydrogen check elimination phase fixed. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Incorrect handling of HTransitionElementsKind in hydrogen check elimination phase fixed. BUG=chromium:460917 LOG=Y Committed: https://crrev.com/0902b5f4dfdea599bf3d96fb9fb258904aff84ec Cr-Commit-Position: refs/heads/master@{#27154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -11 lines) Patch
M src/hydrogen-check-elimination.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +18 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-460917.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
4 years, 8 months ago (2015-03-12 09:30:22 UTC) #2
Benedikt Meurer
Nice catch, thanks Jakob. LGTM
4 years, 8 months ago (2015-03-12 11:43:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000893003/1
4 years, 8 months ago (2015-03-12 11:43:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2015-03-12 11:44:29 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2015-03-12 11:44:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0902b5f4dfdea599bf3d96fb9fb258904aff84ec
Cr-Commit-Position: refs/heads/master@{#27154}

Powered by Google App Engine
This is Rietveld 408576698