Add WebSocketDispatcherHostTest.InvalidScheme

Add WebSocketDispatcherHostTest.InvalidScheme

This is a regression test for
https://codereview.chromium.org/998173003/.

BUG=466335
Committed: https://crrev.com/6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871
Cr-Commit-Position: refs/heads/master@{#320262}

[hiroshige, 2015-03-12 09:10:12]

hiroshige@chromium.org changed reviewers:
+ ricea@chromium.org

[hiroshige, 2015-03-12 09:11:13]

PTAL.

I expect the current tries on trybots fail, and will turn green after
https://codereview.chromium.org/998173003/ is landed.

[Adam Rice, 2015-03-12 09:17:53]

https://codereview.chromium.org/1000883004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/websocket_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/1000883004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/websocket_dispatcher_host_unittest.cc:431: //
MockWebSocketHost do not call WebSocketHost::OnMessageReceived() for
s/do not call/does not call/

https://codereview.chromium.org/1000883004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/websocket_dispatcher_host_unittest.cc:432: //
WebSocketHostMsg_AddChannelRequest by default.
Remove "by default". The sentence is clearer without it.

[hiroshige, 2015-03-12 09:21:22]

https://codereview.chromium.org/1000883004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/websocket_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/1000883004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/websocket_dispatcher_host_unittest.cc:431: //
MockWebSocketHost do not call WebSocketHost::OnMessageReceived() for
On 2015/03/12 09:17:53, Adam Rice wrote:
> s/do not call/does not call/

Done.

https://codereview.chromium.org/1000883004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/websocket_dispatcher_host_unittest.cc:432: //
WebSocketHostMsg_AddChannelRequest by default.
On 2015/03/12 09:17:53, Adam Rice wrote:
> Remove "by default". The sentence is clearer without it.

Done.

[Adam Rice, 2015-03-12 09:53:34]

lgtm after adding comment.

https://codereview.chromium.org/1000883004/diff/20001/content/browser/rendere...
File content/browser/renderer_host/websocket_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/1000883004/diff/20001/content/browser/rendere...
content/browser/renderer_host/websocket_dispatcher_host_unittest.cc:413:
TEST_F(WebSocketDispatcherHostTest, InvalidScheme) {
Please add a comment such as

// This is a regression test for https://crrev.com/998173003/

so that people don't need to search through the git history to see why this test
is here.

[hiroshige, 2015-03-12 09:57:48]

https://codereview.chromium.org/1000883004/diff/20001/content/browser/rendere...
File content/browser/renderer_host/websocket_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/1000883004/diff/20001/content/browser/rendere...
content/browser/renderer_host/websocket_dispatcher_host_unittest.cc:413:
TEST_F(WebSocketDispatcherHostTest, InvalidScheme) {
On 2015/03/12 09:53:34, Adam Rice wrote:
> Please add a comment such as
> 
> // This is a regression test for https://crrev.com/998173003/
> 
> so that people don't need to search through the git history to see why this
test
> is here.

Done.

[Adam Rice, 2015-03-12 10:26:13]

lgtm ps2

[hiroshige, 2015-03-12 10:39:04]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2015-03-12 10:39:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000883004/40001

[commit-bot: I haz the power, 2015-03-12 11:07:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-12 11:08:23]

Patchset 3 (id:??) landed as
https://crrev.com/6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871
Cr-Commit-Position: refs/heads/master@{#320262}

[hiroshige, 2015-03-16 10:30:52]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1007263002/ by hiroshige@chromium.org.

The reason for reverting is: Speculatively revert for https://crbug.com/467471.