Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: sandbox/win/src/broker_services.cc

Issue 1000863006: Adding one more error code to convey process creation/spawn target error to the caller BrokerServic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sandbox/win/src/sandbox_types.h » ('j') | sandbox/win/src/sandbox_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/broker_services.cc
diff --git a/sandbox/win/src/broker_services.cc b/sandbox/win/src/broker_services.cc
index d88e5eba0192335af1df721ea3ca7dd80d3e3d76..120c12755cafebbf1f5f79357ad6598042dfd13a 100644
--- a/sandbox/win/src/broker_services.cc
+++ b/sandbox/win/src/broker_services.cc
@@ -487,8 +487,10 @@ ResultCode BrokerServicesBase::SpawnTarget(const wchar_t* exe_path,
DWORD win_result = target->Create(exe_path, command_line, inherit_handles,
policy_base->GetLowBoxSid() ? true : false,
startup_info, &process_info);
- if (ERROR_SUCCESS != win_result)
- return SpawnCleanup(target, win_result);
+ if (ERROR_SUCCESS != win_result) {
+ SpawnCleanup(target, win_result);
+ return SBOX_ERROR_PROCESS_CREATE;
+ }
// Now the policy is the owner of the target.
if (!policy_base->AddTarget(target)) {
« no previous file with comments | « no previous file | sandbox/win/src/sandbox_types.h » ('j') | sandbox/win/src/sandbox_types.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698