Adding one more error code to convey process creation/spawn target error to the caller BrokerServic…

Adding one more error code to convey process creation/spawn target error to the caller BrokerServices.

The code to use this error code will be in follow-up CL. This will be useful to differentiate UMA for launch errors.

R=rvargas@chromium.org,cpu@chromium.org,jschuh@chromium.org
BUG=

Committed: https://crrev.com/3b26c1d230289b35f6c77d6aabb8464b15680ad7
Cr-Commit-Position: refs/heads/master@{#322104}

[jschuh, 2015-03-24 22:58:55]

lgtm, but change the name.

https://codereview.chromium.org/1000863006/diff/1/sandbox/win/src/sandbox_typ...
File sandbox/win/src/sandbox_types.h (right):

https://codereview.chromium.org/1000863006/diff/1/sandbox/win/src/sandbox_typ...
sandbox/win/src/sandbox_types.h:49: SBOX_ERROR_PROCESS_CREATE = 18,
This is a really stupid nit, but since the convention on Windows is CreateProces
I would prefer the name be ERROR_CREATE_PROCESS.

[Shrikant Kelkar, 2015-03-24 23:11:45]

https://codereview.chromium.org/1000863006/diff/1/sandbox/win/src/sandbox_typ...
File sandbox/win/src/sandbox_types.h (right):

https://codereview.chromium.org/1000863006/diff/1/sandbox/win/src/sandbox_typ...
sandbox/win/src/sandbox_types.h:49: SBOX_ERROR_PROCESS_CREATE = 18,
On 2015/03/24 22:58:55, jschuh wrote:
> This is a really stupid nit, but since the convention on Windows is
CreateProces
> I would prefer the name be ERROR_CREATE_PROCESS.

Done.

[Shrikant Kelkar, 2015-03-24 23:36:01]

The CQ bit was checked by shrikant@chromium.org

[Shrikant Kelkar, 2015-03-24 23:36:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jschuh@chromium.org
Link to the patchset: https://codereview.chromium.org/1000863006/#ps20001
(title: "Changed name.")

[commit-bot: I haz the power, 2015-03-24 23:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000863006/20001

[commit-bot: I haz the power, 2015-03-25 00:29:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-25 00:30:37]

Patchset 2 (id:??) landed as
https://crrev.com/3b26c1d230289b35f6c77d6aabb8464b15680ad7
Cr-Commit-Position: refs/heads/master@{#322104}