Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1000863005: Roll the network service to https://crrev.com/321809 (Closed)

Created:
5 years, 9 months ago by yzshen1
Modified:
5 years, 9 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
yzshen1
Hi, Benjamin. Would you please take a look? Thanks!
5 years, 9 months ago (2015-03-23 19:29:13 UTC) #2
qsr
lgtm
5 years, 9 months ago (2015-03-24 08:21:24 UTC) #3
yzshen1
5 years, 9 months ago (2015-03-24 16:32:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca4648691d3ebe8461344fa0381db25592f3b040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698