Issue 1000863002: Fix errors in Sky detected by Dart analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1000863002: Fix errors in Sky detected by Dart analyzer (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
M	sky/examples/fn/lib/fakesky.dart	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	sky/framework/animation/timer.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/framework/components/button.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/framework/components/checkbox.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/framework/components/floating_action_button.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/framework/components/material.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/framework/components/radio.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-12 05:04:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c7c4380ffdb66b987d09cb78aaf7ff3bfd33e80a (presubmit successful).