Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1000833002: Revert of Add GN For hpack fuzzing utilities and net_perftests. (Closed)

Created:
5 years, 9 months ago by ananta
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add GN For hpack fuzzing utilities and net_perftests. (patchset #5 id:80001 of https://codereview.chromium.org/936313002/) Reason for revert: This causes a compile failure on the Windows 8 GN builder http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/4271 Original issue's description: > Add GN For hpack fuzzing utilities and net_perftests. > > This also adapts net GN targets to use the new size_t->int warning suppression config in //build/config/compiler instead of a locally defined config. > > BUG= > > Committed: https://crrev.com/707a56a6f0e56138fcef5db3ba7ace1ac3cb83eb > Cr-Commit-Position: refs/heads/master@{#320187} TBR=mmenke@chromium.org,dpranke@chromium.org,brettw@chromium.org,rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a588ba9a09a8149236551231beed523800382901 Cr-Commit-Position: refs/heads/master@{#320206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -100 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M build/config/compiler/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M build/gn_migration.gypi View 6 chunks +8 lines, -7 lines 0 comments Download
M net/BUILD.gn View 3 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
Created Revert of Add GN For hpack fuzzing utilities and net_perftests.
5 years, 9 months ago (2015-03-12 02:11:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000833002/1
5 years, 9 months ago (2015-03-12 02:12:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 02:13:28 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 02:14:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a588ba9a09a8149236551231beed523800382901
Cr-Commit-Position: refs/heads/master@{#320206}

Powered by Google App Engine
This is Rietveld 408576698