Move lonely FirstRunUtil method to SignInManager.

Move lonely FirstRunUtil method to SignInManager.

FirstRunUtil had mostly to do with Signing in (it is also used by SignInPromoDialog)
so it should live under org.chromium.chrome.browser.signin.

BUG=428842
Committed: https://crrev.com/c69524bafacc6661173ce8d3f600cdeaa070c68f
Cr-Commit-Position: refs/heads/master@{#321826}

[aurimas (slooooooooow), 2015-03-12 00:41:48]

aurimas@chromium.org changed reviewers:
+ nyquist@chromium.org

[aurimas (slooooooooow), 2015-03-12 00:41:49]

nyquist: PTAL

[nyquist, 2015-03-12 16:55:31]

Please don't land this as is; but instead just make the FirstRunUtil act as an
indirection to the new place. This will simplify things for the autoroller. But
the premise of this CL is OK though.

https://codereview.chromium.org/1000823002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunUtil.java
(left):

https://codereview.chromium.org/1000823002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunUtil.java:20:
public class FirstRunUtil {
Mark this class as @Deprecated (and/or its members).

https://codereview.chromium.org/1000823002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunUtil.java:26:
public static final int SIGNIN_TYPE_INTERACTIVE = 0;
This will cause a breakage and can not be rolled in by the auto-roller. Please
keep all these constants by just referring to the new place here:
public static final int SIGNIN_TYPE_INTERACTIVE =
SigninManager.SIGNIN_TYPE_INTERACTIVE;

https://codereview.chromium.org/1000823002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunUtil.java:52:
public static void signInToSelectedAccount(final Activity activity,
Please make this method call SigninManager.signInToSelectedAccount

https://codereview.chromium.org/1000823002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
(right):

https://codereview.chromium.org/1000823002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:506:
public void signInToSelectedAccount(final Activity activity, final Account
account,
Please add a static method that calls
SigninManger.get(activity).signInToSelectedAccount(...). That method should be
called from the deprecated FirstRunUtil.

[nyquist, 2015-03-23 17:45:55]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2015-03-23 17:45:56]

Begrudgingly lgtm since aurimas@ promised to closely follow this CL through the
steps of rolling it in downstream and I'm sheriffing today.

The change itself (regardless of the step done to get to the end goal) is a good
one! :-)

[commit-bot: I haz the power, 2015-03-23 17:46:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000823002/40001

[aurimas (slooooooooow), 2015-03-23 17:48:18]

The CQ bit was unchecked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-03-23 17:54:38]

PTAL at the update change.

[nyquist, 2015-03-23 18:21:20]

much LGTM. so wow

[aurimas (slooooooooow), 2015-03-23 18:23:56]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-03-23 18:24:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000823002/60001

[commit-bot: I haz the power, 2015-03-23 19:03:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-23 19:04:24]

Patchset 4 (id:??) landed as
https://crrev.com/c69524bafacc6661173ce8d3f600cdeaa070c68f
Cr-Commit-Position: refs/heads/master@{#321826}