Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: build/android/findbugs_filter/findbugs_exclude.xml

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/findbugs_filter/findbugs_exclude.xml
diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml
index 5060e4745d3826628b41f68f223893820f2642fe..6e8d8ba5e4988a68fb31010d627778fd8c1852c0 100644
--- a/build/android/findbugs_filter/findbugs_exclude.xml
+++ b/build/android/findbugs_filter/findbugs_exclude.xml
@@ -17,7 +17,6 @@ In particular, ~ at the start of a string means it's a regex.
<Match>
<Class name="~org\.chromium\..*\.Manifest(\$\w+)?" />
</Match>
- <!-- Ignore "reliance on default String encoding" warnings, as we're not multi-platform -->
<Match>
<Class name="~org\.chromium\.chrome\.browser\.ChromiumApplication.*" />
<Method name="onCancel" />
@@ -28,6 +27,8 @@ In particular, ~ at the start of a string means it's a regex.
<Method name="onClick" />
<Bug code="Dm" />
</Match>
+ <Bug pattern="DM_STRING_CTOR" />
+ <!-- Ignore "reliance on default String encoding" warnings, as we're not multi-platform -->
<Bug pattern="DM_DEFAULT_ENCODING" />
<!-- Ignore bugs that are often false-positives in test code -->
<Match>

Powered by Google App Engine
This is Rietveld 408576698