components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java ('k') | components/cronet/android/test/src/org/chromium/net/CronetTestActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

index e5e5e5db01f072d70cc91c73a015fe5d6adda205..133d673a466cea58c22b49a0c81f25821009b566 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

@@ -7,6 +7,7 @@ package org.chromium.net.urlconnection;

import android.os.Build;

import android.test.suitebuilder.annotation.SmallTest;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.util.Feature;

import org.chromium.net.CronetTestActivity;

import org.chromium.net.CronetTestBase;

@@ -168,6 +169,7 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {

checkExceptionsAreThrown(urlConnection);

}

+ @SuppressFBWarnings("DLS_DEAD_LOCAL_STORE")

@SmallTest

@Feature({"Cronet"})

@CompareDefaultWithCronet

@@ -432,6 +434,7 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {

connection.disconnect();

}

+ @SuppressFBWarnings("DLS_DEAD_LOCAL_STORE")

@SmallTest

@Feature({"Cronet"})

@CompareDefaultWithCronet