base/android/javatests/src/org/chromium/base/ObserverListTest.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/javatests/src/org/chromium/base/ObserverListTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java ('k') | build/android/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/javatests/src/org/chromium/base/ObserverListTest.java

diff --git a/base/android/javatests/src/org/chromium/base/ObserverListTest.java b/base/android/javatests/src/org/chromium/base/ObserverListTest.java

index 599534a2e996100c75d11a6780e386893058c41e..c28d51d72eea25e86add47b478d9477b1fc86401 100644

--- a/base/android/javatests/src/org/chromium/base/ObserverListTest.java

+++ b/base/android/javatests/src/org/chromium/base/ObserverListTest.java

@@ -248,7 +248,6 @@ public class ObserverListTest extends InstrumentationTestCase {

// If we remove an object while iterating, it will be replaced by 'null'.

observerList.addObserver(a);

- Iterator<Object> iterator = observerList.iterator();

assertTrue(observerList.removeObserver(a));

assertFalse(observerList.removeObserver(null));

}

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java ('k') | build/android/PRESUBMIT.py » ('j') | no next file with comments »