android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/ResourcesContextWrapperFactory.java ('k') | android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java

index 0a49a49f566ae767eb09ffffc7031c0f5482ae09..7b10cabee8cba7c6f3a8a3f4e2c30009b52750f6 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebBackForwardListChromium.java

@@ -7,6 +7,7 @@ package com.android.webview.chromium;

import android.webkit.WebBackForwardList;

import android.webkit.WebHistoryItem;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.content_public.browser.NavigationHistory;

import java.util.ArrayList;

@@ -16,6 +17,9 @@ import java.util.List;

* WebView Chromium implementation of WebBackForwardList. Simple immutable

* wrapper around NavigationHistory.

+@SuppressFBWarnings({

+ "CHROMIUM_SYNCHRONIZED_METHOD",

+ "SE_BAD_FIELD"})

public class WebBackForwardListChromium extends WebBackForwardList {

private final List<WebHistoryItemChromium> mHistroryItemList;

private final int mCurrentIndex;