third_party/cacheinvalidation/cacheinvalidation.gyp - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/cacheinvalidation/cacheinvalidation.gyp

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add gn option, address Yaron's comment, rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/findbugs_diff.py ('K') | « content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java ('k') | tools/android/findbugs_plugin/findbugs.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/cacheinvalidation/cacheinvalidation.gyp

diff --git a/third_party/cacheinvalidation/cacheinvalidation.gyp b/third_party/cacheinvalidation/cacheinvalidation.gyp

index 703033c976df5c90fd3eacda83432b1e9e12f4cb..77558075b3c659b0df5aca9057315349d7bb638e 100644

--- a/third_party/cacheinvalidation/cacheinvalidation.gyp

+++ b/third_party/cacheinvalidation/cacheinvalidation.gyp

@@ -228,6 +228,7 @@

'variables': {

'java_in_dir': '../../build/android/empty',

'additional_src_dirs': [ 'src/java/' ],

+ 'run_findbugs': 0,

'includes': [ '../../build/java.gypi' ],