build/android/buildbot/bb_run_bot.py - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_run_bot.py

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add gn option, address Yaron's comment, rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/buildbot/bb_run_bot.py

diff --git a/build/android/buildbot/bb_run_bot.py b/build/android/buildbot/bb_run_bot.py

index 29cce1bc720927fe47db318bb93a251bcee89ac9..4682aeaae23731286f24beda7b91b7ed0bd09c9d 100755

--- a/build/android/buildbot/bb_run_bot.py

+++ b/build/android/buildbot/bb_run_bot.py

@@ -117,8 +117,7 @@ def GetBotStepMap():

compile_step = ['compile']

chrome_proxy_tests = ['chrome_proxy']

python_unittests = ['python_unittests']

- std_host_tests = ['check_webview_licenses', 'findbugs']

- emma_coverage_tests = [x for x in std_host_tests if x is not 'findbugs']

+ std_host_tests = ['check_webview_licenses']

std_build_steps = ['compile', 'zip_build']

std_test_steps = ['extract_build']

std_tests = ['ui', 'unit']

@@ -164,7 +163,7 @@ def GetBotStepMap():

B('fyi-x86-builder-dbg',

H(compile_step + std_host_tests, experimental, target_arch='ia32')),

B('fyi-builder-dbg',

- H(std_build_steps + emma_coverage_tests, experimental,

+ H(std_build_steps + std_host_tests, experimental,

extra_gyp='emma_coverage=1')),

B('x86-builder-dbg',

H(compile_step + std_host_tests, target_arch='ia32')),

« no previous file with comments | « build/android/buildbot/bb_host_steps.py ('k') | build/android/findbugs_action.gypi » ('j') | build/android/findbugs_diff.py » ('J')