android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add gn option, address Yaron's comment, rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java ('k') | android_webview/java/src/org/chromium/android_webview/AwContentsClient.java » ('j') | build/android/findbugs_diff.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index a61311ce800572731cec779038efb12f2a33066e..36329f26b68b6ea47af9119d036b6458759cf174 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -46,6 +46,7 @@ import org.chromium.base.JNINamespace;

import org.chromium.base.ThreadUtils;

import org.chromium.base.TraceEvent;

import org.chromium.base.VisibleForTesting;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.components.navigation_interception.InterceptNavigationDelegate;

import org.chromium.components.navigation_interception.NavigationParams;

import org.chromium.content.browser.ContentViewClient;

@@ -2422,6 +2423,7 @@ public class AwContents implements SmartClipProvider,

}

// Called as a result of nativeUpdateLastHitTestData.

+ @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")

@CalledByNative

private void updateHitTestData(

int type, String extra, String href, String anchorText, String imgSrc) {