[Android] Incorporate findbugs into android builds.

build/java.gypi

Index: build/java.gypi
diff --git a/build/java.gypi b/build/java.gypi
index 061dff2ad7bdaef2228f2d7cff751ed77bf46b49..d7f5f6586a41e2df8c38064d8c7d2ff045d4f0be 100644
--- a/build/java.gypi
+++ b/build/java.gypi
@@ -77,6 +77,8 @@
     'lint_result': '<(intermediate_dir)/lint_result.xml',
     'lint_config': '<(intermediate_dir)/lint_config.xml',
     'never_lint%': 0,
+    'findbugs_stamp': '<(intermediate_dir)/findbugs.stamp',
+    'run_findbugs%': 1,

[cjhopman, 2015/03/17 01:31:16]

I think this will have to default to off, when I looked at doing this some time
ago, running findbugs definitely increased build times (particularly incremental
build times).

[jbudorick, 2015/03/17 01:39:47]

I'm fine with starting it that way, although I think the only places where it'll
matter would be on the main waterfall builders and whichever trybot we're
running tests on (currently, linux_android_rel_ng).

I would like to have this enabled on one of the bots on the CQ (probably
android_compile_dbg), though.

[cjhopman, 2015/03/17 01:55:04]

I'm more concerned about build time for developers, not bots.

We should definitely enable this for at least one of the CQ bots.

[jbudorick, 2015/03/17 03:03:18]

That's a fair point as well.

     'proguard_config%': '',
     'proguard_preprocess%': '0',
     'variables': {
@@ -217,6 +219,31 @@
         },
       ],
     }],
+    ['run_findbugs == 1', {
+      'actions': [
+        {
+          'action_name': 'findbugs_<(_target_name)',
+          'message': 'Running findbugs on <(_target_name)',
+          'inputs': [
+            '<(DEPTH)/build/android/findbugs_diff.py',
+            '<(DEPTH)/build/android/findbugs_filter/findbugs_exclude.xml',
+            '<(DEPTH)/build/android/pylib/utils/findbugs.py',
+            '>@(input_jars_paths)',
+            '<(jar_final_path)',
+            '<(compile_stamp)',
+          ],
+          'outputs': [
+            '<(findbugs_stamp)',
+          ],
+          'action': [
+            'python', '<(DEPTH)/build/android/findbugs_diff.py',
+            '--auxclasspath-gyp', '>(input_jars_paths)',
+            '--stamp', '<(findbugs_stamp)',
+            '<(jar_final_path)',
+          ],
+        },
+      ],
+    }],
   ],
   'actions': [
     {