tools/android/findbugs_plugin/findbugs.xml - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/android/findbugs_plugin/findbugs.xml

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/cacheinvalidation/cacheinvalidation.gyp ('k') | tools/android/findbugs_plugin/findbugs_plugin.gyp » ('j') | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!--	2 <!--

3 Copyright (c) 2012 The Chromium Authors. All rights reserved.	3 Copyright (c) 2012 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <FindbugsPlugin xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"	8 <FindbugsPlugin xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

9 xsi:noNamespaceSchemaLocation="findbugsplugin.xsd"	9 xsi:noNamespaceSchemaLocation="findbugsplugin.xsd"

10 pluginid="SynchronizedThisDetector"	10 pluginid="SynchronizedThisDetector"

11 provider="chromium"	11 provider="chromium"

12 website="http://code.google.com/p/chromium/wiki/UseFindBugsForAndroid">	12 website="http://code.google.com/p/chromium/wiki/UseFindBugsForAndroid">

13 <Detector class="org.chromium.tools.findbugs.plugin.SynchronizedThisDete ctor" reports="CHROMIUM_SYNCHRONIZED_THIS" />	13 <Detector class="org.chromium.tools.findbugs.plugin.SynchronizedThisDete ctor" reports="CHROMIUM_SYNCHRONIZED_THIS" />

14 <BugPattern type="CHROMIUM_SYNCHRONIZED_THIS" abbrev="CST" category="COR RECTNESS"/>	14 <BugPattern type="CHROMIUM_SYNCHRONIZED_THIS" abbrev="CHROMIUM" category ="CORRECTNESS"/>

15	15

16 <Detector class="org.chromium.tools.findbugs.plugin.SynchronizedMethodDe tector" reports="CHROMIUM_SYNCHRONIZED_METHOD" />	16 <Detector class="org.chromium.tools.findbugs.plugin.SynchronizedMethodDe tector" reports="CHROMIUM_SYNCHRONIZED_METHOD" />

17 <BugPattern type="CHROMIUM_SYNCHRONIZED_METHOD" abbrev="CSM" category="C ORRECTNESS"/>	17 <BugPattern type="CHROMIUM_SYNCHRONIZED_METHOD" abbrev="CHROMIUM" catego ry="CORRECTNESS"/>

18 </FindbugsPlugin>	18 </FindbugsPlugin>

OLD	NEW