Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout; 7 import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;
8 8
9 import android.test.suitebuilder.annotation.SmallTest; 9 import android.test.suitebuilder.annotation.SmallTest;
10 10
(...skipping 18 matching lines...) Expand all
29 * - The type of injected objects 29 * - The type of injected objects
30 * - The type of their methods 30 * - The type of their methods
31 * - Replacing objects 31 * - Replacing objects
32 * - Removing objects 32 * - Removing objects
33 * - Access control 33 * - Access control
34 * - Calling methods on returned objects 34 * - Calling methods on returned objects
35 * - Multiply injected objects 35 * - Multiply injected objects
36 * - Threading 36 * - Threading
37 * - Inheritance 37 * - Inheritance
38 */ 38 */
39 @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
39 public class JavaBridgeBasicsTest extends JavaBridgeTestBase { 40 public class JavaBridgeBasicsTest extends JavaBridgeTestBase {
40 @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD") 41 @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
41 private class TestController extends Controller { 42 private class TestController extends Controller {
42 private int mIntValue; 43 private int mIntValue;
43 private long mLongValue; 44 private long mLongValue;
44 private String mStringValue; 45 private String mStringValue;
45 private boolean mBooleanValue; 46 private boolean mBooleanValue;
46 47
47 public synchronized void setIntValue(int x) { 48 public synchronized void setIntValue(int x) {
48 mIntValue = x; 49 mIntValue = x;
(...skipping 1002 matching lines...) Expand 10 before | Expand all | Expand 10 after
1051 executeJavaScript("testObject1.method()"); 1052 executeJavaScript("testObject1.method()");
1052 assertEquals(1, mTestController.waitForIntValue()); 1053 assertEquals(1, mTestController.waitForIntValue());
1053 executeJavaScript("testObject2.method()"); 1054 executeJavaScript("testObject2.method()");
1054 assertEquals(2, mTestController.waitForIntValue()); 1055 assertEquals(2, mTestController.waitForIntValue());
1055 executeJavaScript("testObject1.method.call(testObject2)"); 1056 executeJavaScript("testObject1.method.call(testObject2)");
1056 assertEquals(2, mTestController.waitForIntValue()); 1057 assertEquals(2, mTestController.waitForIntValue());
1057 executeJavaScript("testObject2.method.call(testObject1)"); 1058 executeJavaScript("testObject2.method.call(testObject1)");
1058 assertEquals(1, mTestController.waitForIntValue()); 1059 assertEquals(1, mTestController.waitForIntValue());
1059 } 1060 }
1060 } 1061 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698