Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/commands/CommandSenderTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.components.devtools_bridge.commands; 5 package org.chromium.components.devtools_bridge.commands;
6 6
7 import android.test.InstrumentationTestCase; 7 import android.test.InstrumentationTestCase;
8 import android.test.suitebuilder.annotation.SmallTest; 8 import android.test.suitebuilder.annotation.SmallTest;
9 9
10 import junit.framework.Assert; 10 import junit.framework.Assert;
11 11
12 import org.chromium.base.annotations.SuppressFBWarnings;
12 import org.chromium.components.devtools_bridge.RTCConfiguration; 13 import org.chromium.components.devtools_bridge.RTCConfiguration;
13 import org.chromium.components.devtools_bridge.SessionBase; 14 import org.chromium.components.devtools_bridge.SessionBase;
14 15
15 import java.util.ArrayList; 16 import java.util.ArrayList;
16 import java.util.List; 17 import java.util.List;
17 18
18 /** 19 /**
19 * Tests for {@link CommandSender} 20 * Tests for {@link CommandSender}
20 */ 21 */
22 @SuppressFBWarnings("URF_UNREAD_FIELD")
21 public class CommandSenderTest extends InstrumentationTestCase { 23 public class CommandSenderTest extends InstrumentationTestCase {
22 private static final RTCConfiguration CONFIG = new RTCConfiguration.Builder( ) 24 private static final RTCConfiguration CONFIG = new RTCConfiguration.Builder( )
23 .addIceServer("http://example.org") 25 .addIceServer("http://example.org")
24 .build(); 26 .build();
25 27
26 private Command mCommand; 28 private Command mCommand;
27 private Runnable mCompletionCallback; 29 private Runnable mCompletionCallback;
28 private String mAnswer; 30 private String mAnswer;
29 private String mErrorMessage; 31 private String mErrorMessage;
30 private List<String> mServerCandidates; 32 private List<String> mServerCandidates;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 public void onSuccess(List<String> serverCandidates) { 117 public void onSuccess(List<String> serverCandidates) {
116 mServerCandidates = serverCandidates; 118 mServerCandidates = serverCandidates;
117 } 119 }
118 120
119 @Override 121 @Override
120 public void onFailure(String errorMessage) { 122 public void onFailure(String errorMessage) {
121 mErrorMessage = errorMessage; 123 mErrorMessage = errorMessage;
122 } 124 }
123 } 125 }
124 } 126 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698