Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 _DELETIONS_ONLY_FILES = (
12 'build/android/findbugs_filter/findbugs_known_bugs.txt',
13 )
14
15
16 def _CheckDeletionsOnlyFiles(input_api, output_api):
17 """Check that a certain listed files only have deletions.
18 """
19 warnings = []
20 for f in input_api.AffectedFiles():
21 if f.LocalPath() in _DELETIONS_ONLY_FILES:
22 if f.ChangedContents():
23 warnings.append(f.LocalPath())
24 results = []
25 if warnings:
26 results.append(output_api.PresubmitPromptWarning(
27 'Following files should only contain deletions.', warnings))
28 return results
29
30 11
31 def CommonChecks(input_api, output_api): 12 def CommonChecks(input_api, output_api):
32 output = [] 13 output = []
33 14
34 def J(*dirs): 15 def J(*dirs):
35 """Returns a path relative to presubmit directory.""" 16 """Returns a path relative to presubmit directory."""
36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) 17 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
37 18
38 output.extend(input_api.canned_checks.RunPylint( 19 output.extend(input_api.canned_checks.RunPylint(
39 input_api, 20 input_api,
(...skipping 23 matching lines...) Expand all
63 unit_tests=[ 44 unit_tests=[
64 J('pylib', 'device', 'device_utils_test.py'), 45 J('pylib', 'device', 'device_utils_test.py'),
65 J('pylib', 'device', 'logcat_monitor_test.py'), 46 J('pylib', 'device', 'logcat_monitor_test.py'),
66 J('pylib', 'gtest', 'gtest_test_instance_test.py'), 47 J('pylib', 'gtest', 'gtest_test_instance_test.py'),
67 J('pylib', 'instrumentation', 48 J('pylib', 'instrumentation',
68 'instrumentation_test_instance_test.py'), 49 'instrumentation_test_instance_test.py'),
69 J('pylib', 'results', 'json_results_test.py'), 50 J('pylib', 'results', 'json_results_test.py'),
70 J('pylib', 'utils', 'md5sum_test.py'), 51 J('pylib', 'utils', 'md5sum_test.py'),
71 ], 52 ],
72 env=pylib_test_env)) 53 env=pylib_test_env))
73 # TODO(jbudorick): Reenable this check once upstreaming is finished.
74 # output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))
75 return output 54 return output
76 55
77 56
78 def CheckChangeOnUpload(input_api, output_api): 57 def CheckChangeOnUpload(input_api, output_api):
79 return CommonChecks(input_api, output_api) 58 return CommonChecks(input_api, output_api)
80 59
81 60
82 def CheckChangeOnCommit(input_api, output_api): 61 def CheckChangeOnCommit(input_api, output_api):
83 return CommonChecks(input_api, output_api) 62 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « base/android/javatests/src/org/chromium/base/ObserverListTest.java ('k') | build/android/buildbot/bb_host_steps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698