Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.android_webview.test; 5 package org.chromium.android_webview.test;
6 6
7 import android.os.Build; 7 import android.os.Build;
8 import android.test.suitebuilder.annotation.SmallTest; 8 import android.test.suitebuilder.annotation.SmallTest;
9 9
10 import org.chromium.android_webview.AwContents; 10 import org.chromium.android_webview.AwContents;
11 import org.chromium.android_webview.test.util.CommonResources; 11 import org.chromium.android_webview.test.util.CommonResources;
12 import org.chromium.base.ThreadUtils; 12 import org.chromium.base.ThreadUtils;
13 import org.chromium.base.annotations.SuppressFBWarnings;
13 import org.chromium.base.test.util.DisabledTest; 14 import org.chromium.base.test.util.DisabledTest;
14 import org.chromium.base.test.util.MinAndroidSdkLevel; 15 import org.chromium.base.test.util.MinAndroidSdkLevel;
15 import org.chromium.content.browser.test.util.HistoryUtils; 16 import org.chromium.content.browser.test.util.HistoryUtils;
16 import org.chromium.content.browser.test.util.TestCallbackHelperContainer; 17 import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
17 import org.chromium.content_public.browser.NavigationEntry; 18 import org.chromium.content_public.browser.NavigationEntry;
18 import org.chromium.content_public.browser.NavigationHistory; 19 import org.chromium.content_public.browser.NavigationHistory;
19 import org.chromium.net.test.util.TestWebServer; 20 import org.chromium.net.test.util.TestWebServer;
20 21
21 import java.util.concurrent.Callable; 22 import java.util.concurrent.Callable;
22 23
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 // submitted login page after visiting the help page. 270 // submitted login page after visiting the help page.
270 /** 271 /**
271 * Temporarily disabled. It is blocking a patch that fixes chromium's form 272 * Temporarily disabled. It is blocking a patch that fixes chromium's form
272 * resubmission defenses. This test should probably expect a modal dialog 273 * resubmission defenses. This test should probably expect a modal dialog
273 * asking permission to re-post rather than expecting to just be able to nav igate 274 * asking permission to re-post rather than expecting to just be able to nav igate
274 * back to a page that specified Cache-Control: no-store. 275 * back to a page that specified Cache-Control: no-store.
275 * 276 *
276 * @MediumTest 277 * @MediumTest
277 * @Feature({"AndroidWebView"}) 278 * @Feature({"AndroidWebView"})
278 */ 279 */
280 @SuppressFBWarnings("DLS_DEAD_LOCAL_STORE")
279 @DisabledTest 281 @DisabledTest
280 public void testNavigateBackToNoncacheableLoginPage() throws Throwable { 282 public void testNavigateBackToNoncacheableLoginPage() throws Throwable {
281 final TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHel per = 283 final TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHel per =
282 mContentsClient.getOnPageFinishedHelper(); 284 mContentsClient.getOnPageFinishedHelper();
283 285
284 final String loginPageUrl = addNoncacheableLoginPageToServer(mWebServer) ; 286 final String loginPageUrl = addNoncacheableLoginPageToServer(mWebServer) ;
285 final String loginResponsePageUrl = addNoncacheableLoginResponsePageToSe rver(mWebServer); 287 final String loginResponsePageUrl = addNoncacheableLoginResponsePageToSe rver(mWebServer);
286 final String page1Url = addPage1ToServer(mWebServer); 288 final String page1Url = addPage1ToServer(mWebServer);
287 289
288 getAwSettingsOnUiThread(mAwContents).setJavaScriptEnabled(true); 290 getAwSettingsOnUiThread(mAwContents).setJavaScriptEnabled(true);
(...skipping 23 matching lines...) Expand all
312 onPageFinishedHelper); 314 onPageFinishedHelper);
313 pollOnUiThread(new Callable<Boolean>() { 315 pollOnUiThread(new Callable<Boolean>() {
314 @Override 316 @Override
315 public Boolean call() { 317 public Boolean call() {
316 String title = mAwContents.getTitle(); 318 String title = mAwContents.getTitle();
317 return LOGIN_RESPONSE_PAGE_TITLE.equals(title); 319 return LOGIN_RESPONSE_PAGE_TITLE.equals(title);
318 } 320 }
319 }); 321 });
320 } 322 }
321 } 323 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698