Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.android_webview; 5 package org.chromium.android_webview;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.app.Activity; 8 import android.app.Activity;
9 import android.content.ComponentCallbacks2; 9 import android.content.ComponentCallbacks2;
10 import android.content.Context; 10 import android.content.Context;
(...skipping 28 matching lines...) Expand all
39 import android.webkit.JavascriptInterface; 39 import android.webkit.JavascriptInterface;
40 import android.webkit.ValueCallback; 40 import android.webkit.ValueCallback;
41 import android.widget.OverScroller; 41 import android.widget.OverScroller;
42 42
43 import org.chromium.android_webview.permission.AwPermissionRequest; 43 import org.chromium.android_webview.permission.AwPermissionRequest;
44 import org.chromium.base.CalledByNative; 44 import org.chromium.base.CalledByNative;
45 import org.chromium.base.JNINamespace; 45 import org.chromium.base.JNINamespace;
46 import org.chromium.base.ThreadUtils; 46 import org.chromium.base.ThreadUtils;
47 import org.chromium.base.TraceEvent; 47 import org.chromium.base.TraceEvent;
48 import org.chromium.base.VisibleForTesting; 48 import org.chromium.base.VisibleForTesting;
49 import org.chromium.base.annotations.SuppressFBWarnings;
49 import org.chromium.components.navigation_interception.InterceptNavigationDelega te; 50 import org.chromium.components.navigation_interception.InterceptNavigationDelega te;
50 import org.chromium.components.navigation_interception.NavigationParams; 51 import org.chromium.components.navigation_interception.NavigationParams;
51 import org.chromium.content.browser.ContentViewClient; 52 import org.chromium.content.browser.ContentViewClient;
52 import org.chromium.content.browser.ContentViewCore; 53 import org.chromium.content.browser.ContentViewCore;
53 import org.chromium.content.browser.ContentViewStatics; 54 import org.chromium.content.browser.ContentViewStatics;
54 import org.chromium.content.browser.SmartClipProvider; 55 import org.chromium.content.browser.SmartClipProvider;
55 import org.chromium.content.common.CleanupReference; 56 import org.chromium.content.common.CleanupReference;
56 import org.chromium.content_public.browser.GestureStateListener; 57 import org.chromium.content_public.browser.GestureStateListener;
57 import org.chromium.content_public.browser.JavaScriptCallback; 58 import org.chromium.content_public.browser.JavaScriptCallback;
58 import org.chromium.content_public.browser.LoadUrlParams; 59 import org.chromium.content_public.browser.LoadUrlParams;
(...skipping 2356 matching lines...) Expand 10 before | Expand all | Expand 10 after
2415 // (see synchronous_compositor_impl.cc and crbug/452530). 2416 // (see synchronous_compositor_impl.cc and crbug/452530).
2416 mHandler.post(new Runnable() { 2417 mHandler.post(new Runnable() {
2417 @Override 2418 @Override
2418 public void run() { 2419 public void run() {
2419 callback.onComplete(requestId); 2420 callback.onComplete(requestId);
2420 } 2421 }
2421 }); 2422 });
2422 } 2423 }
2423 2424
2424 // Called as a result of nativeUpdateLastHitTestData. 2425 // Called as a result of nativeUpdateLastHitTestData.
2426 @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
2425 @CalledByNative 2427 @CalledByNative
2426 private void updateHitTestData( 2428 private void updateHitTestData(
2427 int type, String extra, String href, String anchorText, String imgSr c) { 2429 int type, String extra, String href, String anchorText, String imgSr c) {
2428 mPossiblyStaleHitTestData.hitTestResultType = type; 2430 mPossiblyStaleHitTestData.hitTestResultType = type;
2429 mPossiblyStaleHitTestData.hitTestResultExtraData = extra; 2431 mPossiblyStaleHitTestData.hitTestResultExtraData = extra;
2430 mPossiblyStaleHitTestData.href = href; 2432 mPossiblyStaleHitTestData.href = href;
2431 mPossiblyStaleHitTestData.anchorText = anchorText; 2433 mPossiblyStaleHitTestData.anchorText = anchorText;
2432 mPossiblyStaleHitTestData.imgSrc = imgSrc; 2434 mPossiblyStaleHitTestData.imgSrc = imgSrc;
2433 } 2435 }
2434 2436
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
2993 private native void nativeCreatePdfExporter(long nativeAwContents, AwPdfExpo rter awPdfExporter); 2995 private native void nativeCreatePdfExporter(long nativeAwContents, AwPdfExpo rter awPdfExporter);
2994 2996
2995 private native void nativePreauthorizePermission(long nativeAwContents, Stri ng origin, 2997 private native void nativePreauthorizePermission(long nativeAwContents, Stri ng origin,
2996 long resources); 2998 long resources);
2997 2999
2998 private native void nativePostMessageToFrame(long nativeAwContents, String f rameId, 3000 private native void nativePostMessageToFrame(long nativeAwContents, String f rameId,
2999 String message, String targetOrigin, int[] msgPorts); 3001 String message, String targetOrigin, int[] msgPorts);
3000 3002
3001 private native void nativeCreateMessageChannel(long nativeAwContents, AwMess agePort[] ports); 3003 private native void nativeCreateMessageChannel(long nativeAwContents, AwMess agePort[] ports);
3002 } 3004 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698