Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package com.android.webview.chromium; 5 package com.android.webview.chromium;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.content.res.Configuration; 8 import android.content.res.Configuration;
9 import android.graphics.Bitmap; 9 import android.graphics.Bitmap;
10 import android.graphics.Canvas; 10 import android.graphics.Canvas;
(...skipping 28 matching lines...) Expand all
39 import android.webkit.WebView; 39 import android.webkit.WebView;
40 import android.webkit.WebViewClient; 40 import android.webkit.WebViewClient;
41 import android.webkit.WebViewProvider; 41 import android.webkit.WebViewProvider;
42 import android.widget.TextView; 42 import android.widget.TextView;
43 43
44 import org.chromium.android_webview.AwContents; 44 import org.chromium.android_webview.AwContents;
45 import org.chromium.android_webview.AwContentsStatics; 45 import org.chromium.android_webview.AwContentsStatics;
46 import org.chromium.android_webview.AwPrintDocumentAdapter; 46 import org.chromium.android_webview.AwPrintDocumentAdapter;
47 import org.chromium.android_webview.AwSettings; 47 import org.chromium.android_webview.AwSettings;
48 import org.chromium.base.ThreadUtils; 48 import org.chromium.base.ThreadUtils;
49 import org.chromium.base.annotations.SuppressFBWarnings;
49 import org.chromium.content.browser.SmartClipProvider; 50 import org.chromium.content.browser.SmartClipProvider;
50 51
51 import java.io.BufferedWriter; 52 import java.io.BufferedWriter;
52 import java.io.File; 53 import java.io.File;
53 import java.util.Map; 54 import java.util.Map;
54 import java.util.Queue; 55 import java.util.Queue;
55 import java.util.concurrent.Callable; 56 import java.util.concurrent.Callable;
56 import java.util.concurrent.ConcurrentLinkedQueue; 57 import java.util.concurrent.ConcurrentLinkedQueue;
57 import java.util.concurrent.FutureTask; 58 import java.util.concurrent.FutureTask;
58 import java.util.concurrent.TimeUnit; 59 import java.util.concurrent.TimeUnit;
(...skipping 1075 matching lines...) Expand 10 before | Expand all | Expand 10 after
1134 @Override 1135 @Override
1135 public void run() { 1136 public void run() {
1136 findAllAsync(searchString); 1137 findAllAsync(searchString);
1137 } 1138 }
1138 }); 1139 });
1139 return; 1140 return;
1140 } 1141 }
1141 mAwContents.findAllAsync(searchString); 1142 mAwContents.findAllAsync(searchString);
1142 } 1143 }
1143 1144
1145 @SuppressFBWarnings("RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE")
1144 @Override 1146 @Override
1145 public boolean showFindDialog(final String text, final boolean showIme) { 1147 public boolean showFindDialog(final String text, final boolean showIme) {
1146 mFactory.startYourEngines(false); 1148 mFactory.startYourEngines(false);
1147 if (checkNeedsPost()) { 1149 if (checkNeedsPost()) {
1148 return false; 1150 return false;
1149 } 1151 }
1150 if (mWebView.getParent() == null) { 1152 if (mWebView.getParent() == null) {
1151 return false; 1153 return false;
1152 } 1154 }
1153 1155
(...skipping 997 matching lines...) Expand 10 before | Expand all | Expand 10 after
2151 mAwContents.extractSmartClipData(x, y, width, height); 2153 mAwContents.extractSmartClipData(x, y, width, height);
2152 } 2154 }
2153 2155
2154 // Implements SmartClipProvider 2156 // Implements SmartClipProvider
2155 @Override 2157 @Override
2156 public void setSmartClipResultHandler(final Handler resultHandler) { 2158 public void setSmartClipResultHandler(final Handler resultHandler) {
2157 checkThread(); 2159 checkThread();
2158 mAwContents.setSmartClipResultHandler(resultHandler); 2160 mAwContents.setSmartClipResultHandler(resultHandler);
2159 } 2161 }
2160 } 2162 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698