Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package com.android.webview.chromium; 5 package com.android.webview.chromium;
6 6
7 import android.graphics.Bitmap; 7 import android.graphics.Bitmap;
8 import android.webkit.WebHistoryItem; 8 import android.webkit.WebHistoryItem;
9 9
10 import org.chromium.base.annotations.SuppressFBWarnings;
10 import org.chromium.content_public.browser.NavigationEntry; 11 import org.chromium.content_public.browser.NavigationEntry;
11 12
12 /** 13 /**
13 * WebView Chromium implementation of WebHistoryItem. Simple immutable wrapper 14 * WebView Chromium implementation of WebHistoryItem. Simple immutable wrapper
14 * around NavigationEntry 15 * around NavigationEntry
15 */ 16 */
16 @SuppressWarnings("deprecation") 17 @SuppressWarnings("deprecation")
17 public class WebHistoryItemChromium extends WebHistoryItem { 18 public class WebHistoryItemChromium extends WebHistoryItem {
18 private final String mUrl; 19 private final String mUrl;
19 private final String mOriginalUrl; 20 private final String mOriginalUrl;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 private WebHistoryItemChromium(String url, String originalUrl, String title, Bitmap favicon) { 73 private WebHistoryItemChromium(String url, String originalUrl, String title, Bitmap favicon) {
73 mUrl = url; 74 mUrl = url;
74 mOriginalUrl = originalUrl; 75 mOriginalUrl = originalUrl;
75 mTitle = title; 76 mTitle = title;
76 mFavicon = favicon; 77 mFavicon = favicon;
77 } 78 }
78 79
79 /** 80 /**
80 * See {@link android.webkit.WebHistoryItem#clone}. 81 * See {@link android.webkit.WebHistoryItem#clone}.
81 */ 82 */
83 @SuppressFBWarnings({
84 "CHROMIUM_SYNCHRONIZED_METHOD",
85 "CN_IDIOM_NO_SUPER_CALL"})
82 @Override 86 @Override
83 public synchronized WebHistoryItemChromium clone() { 87 public synchronized WebHistoryItemChromium clone() {
84 return new WebHistoryItemChromium(mUrl, mOriginalUrl, mTitle, mFavicon); 88 return new WebHistoryItemChromium(mUrl, mOriginalUrl, mTitle, mFavicon);
85 } 89 }
86 } 90 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698