[Android] Incorporate findbugs into android builds.

chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.app.AlertDialog;
 import android.content.DialogInterface;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.ThreadUtils;
+import org.chromium.base.annotations.SuppressFBWarnings;
 import org.chromium.base.test.util.Feature;
 import org.chromium.chrome.R;
 import org.chromium.chrome.shell.ChromeShellActivity;
 import org.chromium.chrome.shell.ChromeShellApplication;
 import org.chromium.chrome.shell.ChromeShellTestBase;
 
 /**
  * Tests org.chromium.chrome.browser.webapps.AddToHomescreenDialog by verifying
  * that the calling the show() method actually shows the dialog and checks that
  * some expected elements inside the dialog are present.
  *
  * This is mostly intended as a smoke test because the dialog isn't used in
  * Chromium for the moment.
  */
 public class AddToHomescreenDialogTest extends ChromeShellTestBase {
     private ChromeShellActivity mActivity;
 
+    @SuppressFBWarnings("DLS_DEAD_LOCAL_STORE")
     @Override
     public void setUp() throws Exception {
         super.setUp();
         mActivity = launchChromeShellWithBlankPage();
         ChromeShellApplication application =

[Yaron, 2015/03/23 19:13:16]

I'd prefer it if you just deleted this line as opposed to suppressing

[jbudorick, 2015/03/23 19:49:21]

done + verified that test passed locally without it.

                 (ChromeShellApplication) mActivity.getApplication();
     }
 
     @SmallTest
     @Feature("{Webapp}")
     public void testSmoke() throws InterruptedException {
         assertTrue(waitForActiveShellToBeDoneLoading());
 
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 assertNull(AddToHomescreenDialog.getCurrentDialogForTest());
 
                 AddToHomescreenDialog.show(mActivity, mActivity.getActiveTab());
                 AlertDialog dialog = AddToHomescreenDialog.getCurrentDialogForTest();
                 assertNotNull(dialog);
 
                 assertTrue(dialog.isShowing());
 
                 assertNotNull(dialog.findViewById(R.id.title));
                 assertNotNull(dialog.findViewById(R.id.text));
                 assertNotNull(dialog.getButton(DialogInterface.BUTTON_POSITIVE));
                 assertNotNull(dialog.getButton(DialogInterface.BUTTON_NEGATIVE));
             }
         });
     }
 }