Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 100073004: Fix issues with supervised user recreation (Closed)

Created:
7 years ago by Adrian Kuegel
Modified:
7 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix issues with supervised user recreation. Issues fixed in this CL: - Support high-resolution screens when showing the avatar icons. - Disable import button when there are no supervised users at all to import. - Don't overwrite the synced avatar on ChromeOS. - Improve css properties in the import overlay. A screenshot of the changed import dialog can be found in the bug description of 282464. BUG=282464, 314605 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240091

Patch Set 1 #

Patch Set 2 : Use imageset for avatar icons. #

Patch Set 3 : Improve css properties. #

Patch Set 4 : Add missing imageset statements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M chrome/browser/managed_mode/managed_user_sync_service.cc View 1 3 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/browser_options_profile_list.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/managed_user_import.css View 1 2 2 chunks +18 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/managed_user_import.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/options/managed_user_list.js View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/profiles_icon_grid.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Adrian Kuegel
Pam, can you please review this CL?
7 years ago (2013-12-10 13:59:10 UTC) #1
Pam (message me for reviews)
LGTM! Sorry for the delay. That "also PM for reviews" isn't kidding. :) - Pam
7 years ago (2013-12-11 10:07:11 UTC) #2
Adrian Kuegel
On 2013/12/11 10:07:11, Pam (also PM for reviews) wrote: > LGTM! > > Sorry for ...
7 years ago (2013-12-11 10:15:17 UTC) #3
Pam (message me for reviews)
On 2013/12/11 10:15:17, Adrian Kuegel wrote: > On 2013/12/11 10:07:11, Pam (also PM for reviews) ...
7 years ago (2013-12-11 10:17:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/100073004/50001
7 years ago (2013-12-11 10:17:49 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-11 12:42:58 UTC) #6
Message was sent while issue was closed.
Change committed as 240091

Powered by Google App Engine
This is Rietveld 408576698