telemetry: Add thread time to telmetry timeline.

tools/perf/metrics/rendering_stats_unittest.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import random
 import unittest
 
 from metrics.rendering_stats import RenderingStats
 from telemetry.core.timeline import model
 
@@ skipping 42 matching lines @@
   data = { 'frame_count': 0,
            'paint_time': 0.0,
            'painted_pixel_count': 0,
            'record_time': mock_timer.Advance(2, 4) / 1000.0,
            'recorded_pixel_count': 3000*3000 }
   timestamp = mock_timer.Get()
 
   # Add a slice with the event data to the given thread.
   thread.PushCompleteSlice(
       'benchmark', 'BenchmarkInstrumentation::MainThreadRenderingStats',
-      timestamp, 0.0, {'data': data})
+      timestamp, 0.0, None, None, {'data': data})

[nduca, 2013/12/03 07:18:55]

here and elsewhere, after the timestamp parameter, can you please use
explicitly-named args here so its clear what each argument is?

timestamp, blah=0.0, blah2=None, blah3=None, args={'data'....

[ernstm, 2013/12/03 20:55:54]

Done.

 
   if not ref_stats:
     return
 
   # Add timestamp only if a frame was output
   if data['frame_count'] == 1:
     if not first_frame:
       # Add frame_time if this is not the first frame in within the bounds of an
       # action.
       prev_timestamp = ref_stats.frame_timestamps[-1]
@@ skipping 16 matching lines @@
   """
   # Create randonm data and timestap for impl thread rendering stats.
   data = { 'frame_count': 1,
            'rasterize_time': mock_timer.Advance(5, 10) / 1000.0,
            'rasterized_pixel_count': 1280*720 }
   timestamp = mock_timer.Get()
 
   # Add a slice with the event data to the given thread.
   thread.PushCompleteSlice(
       'benchmark', 'BenchmarkInstrumentation::ImplThreadRenderingStats',
-      timestamp, 0.0, {'data': data})
+      timestamp, 0.0, None, None, {'data': data})
 
   if not ref_stats:
     return
 
   # Add timestamp only if a frame was output
   if data['frame_count'] == 1:
     if not first_frame:
       # Add frame_time if this is not the first frame in within the bounds of an
       # action.
       prev_timestamp = ref_stats.frame_timestamps[-1]
@@ skipping 72 matching lines @@
     self.assertEquals(stats.frame_timestamps, ref_stats.frame_timestamps)
     self.assertEquals(stats.frame_times, ref_stats.frame_times)
     self.assertEquals(stats.rasterize_time, ref_stats.rasterize_time)
     self.assertEquals(stats.rasterized_pixel_count,
                       ref_stats.rasterized_pixel_count)
     self.assertEquals(stats.paint_time, ref_stats.paint_time)
     self.assertEquals(stats.painted_pixel_count, ref_stats.painted_pixel_count)
     self.assertEquals(stats.record_time, ref_stats.record_time)
     self.assertEquals(stats.recorded_pixel_count,
                       ref_stats.recorded_pixel_count)