Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1000723002: MIPS: CpuProfiler: enable tests except four failing tests. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: CpuProfiler: enable tests except four failing tests. Port 84e90b2d0d28229b4107ff350620fc40935c5770 Original commit message: Four tests are failing due to a problem with no frame ranges. TEST=cctest/test-cpu-profiler/CollectDeoptEvents BUG= Committed: https://crrev.com/1320b9dc5fafeaa2087ee46012cc481804a6d50b Cr-Commit-Position: refs/heads/master@{#27152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/cctest/cctest.status View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-11 18:19:09 UTC) #2
paul.l...
LGTM, but needs v8 team review. PTAL. This test often passes, including the latest build ...
5 years, 9 months ago (2015-03-11 18:48:33 UTC) #3
Jakob Kummerow
lgtm
5 years, 9 months ago (2015-03-11 21:10:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000723002/1
5 years, 9 months ago (2015-03-12 10:10:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 10:46:28 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 10:46:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1320b9dc5fafeaa2087ee46012cc481804a6d50b
Cr-Commit-Position: refs/heads/master@{#27152}

Powered by Google App Engine
This is Rietveld 408576698