Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1000523003: Revert of Track how many pages trigger fallback strategies in GC (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Track how many pages trigger fallback strategies in GC (patchset #2 id:20001 of https://codereview.chromium.org/1029323003/) Reason for revert: This seems to cause lots of crashes in layout tests debug: ../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp(67) : void blink::useCounterCallback(v8::Isolate *, v8::Isolate::UseCounte http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2332 Original issue's description: > Track how many pages trigger fallback strategies in GC > > R=hpayer@chromium.org > BUG= > > Committed: https://crrev.com/bb880058f6499510cff12d98dc7d524d35d769cb > Cr-Commit-Position: refs/heads/master@{#27421} TBR=hpayer@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/96cfadd505ecd8337c689442f189ddfd840b3798 Cr-Commit-Position: refs/heads/master@{#27427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M include/v8.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +21 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
Created Revert of Track how many pages trigger fallback strategies in GC
5 years, 9 months ago (2015-03-24 21:57:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000523003/1
5 years, 9 months ago (2015-03-24 21:57:43 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/heap/mark-compact.h: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-24 21:57:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000523003/1
5 years, 9 months ago (2015-03-24 22:02:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 22:02:33 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 22:02:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96cfadd505ecd8337c689442f189ddfd840b3798
Cr-Commit-Position: refs/heads/master@{#27427}

Powered by Google App Engine
This is Rietveld 408576698