Add BeginFrameObserverProxy

content/browser/compositor/delegated_frame_host.cc

Index: content/browser/compositor/delegated_frame_host.cc
diff --git a/content/browser/compositor/delegated_frame_host.cc b/content/browser/compositor/delegated_frame_host.cc
index 026e0e0dba7c2dedfe362aa361ca5f1130d9162b..9822d8f5dca85655fd178f925875007985b6d047 100644
--- a/content/browser/compositor/delegated_frame_host.cc
+++ b/content/browser/compositor/delegated_frame_host.cc
@@ -6,6 +6,7 @@
 
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
+#include "cc/output/begin_frame_args.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/compositor_frame_ack.h"
 #include "cc/output/copy_output_request.h"
@@ -17,6 +18,7 @@
 #include "content/browser/compositor/resize_lock.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/common/gpu/client/gl_helper.h"
+#include "content/common/view_messages.h"
 #include "content/public/browser/render_widget_host_view_frame_subscriber.h"
 #include "content/public/common/content_switches.h"
 #include "media/base/video_frame.h"
@@ -55,7 +57,8 @@ void RequireCallback(cc::SurfaceManager* manager,
 ////////////////////////////////////////////////////////////////////////////////
 // DelegatedFrameHost
 
-DelegatedFrameHost::DelegatedFrameHost(DelegatedFrameHostClient* client)
+DelegatedFrameHost::DelegatedFrameHost(DelegatedFrameHostClient* client,
+                                       bool begin_frame_scheduling_enabled)
     : client_(client),
       compositor_(nullptr),
       use_surfaces_(UseSurfacesEnabled()),
@@ -65,7 +68,9 @@ DelegatedFrameHost::DelegatedFrameHost(DelegatedFrameHostClient* client)
       current_scale_factor_(1.f),
       can_lock_compositor_(YES_CAN_LOCK),
       frame_subscriber_copy_request_pending_(false),
-      delegated_frame_evictor_(new DelegatedFrameEvictor(this)) {
+      delegated_frame_evictor_(new DelegatedFrameEvictor(this)),
+      begin_frame_scheduling_enabled_(begin_frame_scheduling_enabled),
+      needs_begin_frames_(false) {
   ImageTransportFactory::GetInstance()->AddObserver(this);
 }
 
@@ -855,6 +860,25 @@ void DelegatedFrameHost::CopyFromCompositingSurfaceHasResultForVideo(
                                      finished_callback);
 }
 
+void DelegatedFrameHost::OnSetNeedsBeginFrames(bool needs_begin_frames) {
+  DCHECK(begin_frame_scheduling_enabled_);
+
+ if (needs_begin_frames_ == needs_begin_frames)
+   return;
+
+  needs_begin_frames_ = needs_begin_frames;
+
+  // In some cases, BeginFrame is needed before |client_|'s window is added
+  // in the root window hierarchy.
+  if (!compositor_)
+    return;
+
+  if (needs_begin_frames)
+    StartObservingBeginFrames();
+  else
+    StopObservingBeginFrames();
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // DelegatedFrameHost, ui::CompositorObserver implementation:
 
@@ -905,6 +929,8 @@ void DelegatedFrameHost::OnCompositingShuttingDown(ui::Compositor* compositor) {
   DCHECK(!compositor_);
 }
 
+///////////////////////////////////////////////////////////////////////////////
+// ui::CompositorBeginFrameObserver implementation.
 void DelegatedFrameHost::OnUpdateVSyncParameters(
     base::TimeTicks timebase,
     base::TimeDelta interval) {
@@ -914,6 +940,15 @@ void DelegatedFrameHost::OnUpdateVSyncParameters(
     client_->DelegatedFrameHostUpdateVSyncParameters(timebase, interval);
 }
 
+void DelegatedFrameHost::OnSendBeginFrame(const cc::BeginFrameArgs& args) {

[danakj, 2015/03/13 20:04:40]

This code seems entirely disconnected from the other responsibilities of
DelegatedFrameHost, and has nothing to do with hosting frames. Can we tear this
off into a separate class?

[simonhong, 2015/03/17 16:11:34]

Yep, handling BeginFrame message is not related with this class.
I created BeginFrameManager class for it.

+  DCHECK(begin_frame_scheduling_enabled_);
+
+  client_->DelegatedFrameHostSendBeginFrame(args);
+  last_sent_begin_frame_args_ = args;
+  vsync_timebase_ = args.frame_time;
+  vsync_interval_ = args.interval;
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // DelegatedFrameHost, ImageTransportFactoryObserver implementation:
 
@@ -973,6 +1008,9 @@ void DelegatedFrameHost::SetCompositor(ui::Compositor* compositor) {
   DCHECK(!vsync_manager_.get());
   vsync_manager_ = compositor_->vsync_manager();
   vsync_manager_->AddObserver(this);
+
+  if (begin_frame_scheduling_enabled_ && needs_begin_frames_)
+    StartObservingBeginFrames();
 }
 
 void DelegatedFrameHost::ResetCompositor() {
@@ -989,6 +1027,10 @@ void DelegatedFrameHost::ResetCompositor() {
     vsync_manager_->RemoveObserver(this);
     vsync_manager_ = NULL;
   }
+
+  if (begin_frame_scheduling_enabled_ && needs_begin_frames_)
+    StopObservingBeginFrames();
+
   compositor_ = nullptr;
 }
 
@@ -1010,6 +1052,20 @@ void DelegatedFrameHost::UnlockResources() {
   delegated_frame_evictor_->UnlockFrame();
 }
 
+void DelegatedFrameHost::StartObservingBeginFrames() {
+  DCHECK(begin_frame_scheduling_enabled_);
+  DCHECK(compositor_);
+
+  compositor_->AddBeginFrameObserver(this, last_sent_begin_frame_args_);
+}
+
+void DelegatedFrameHost::StopObservingBeginFrames() {
+  DCHECK(begin_frame_scheduling_enabled_);
+  DCHECK(compositor_);
+
+  compositor_->RemoveBeginFrameObserver(this);
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // DelegatedFrameHost, ui::LayerOwnerDelegate implementation: