Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: ui/compositor/compositor_unittest.cc

Issue 1000503002: Add BeginFrameObserverProxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/basictypes.h"
6 #include "base/compiler_specific.h"
7 #include "base/memory/scoped_ptr.h"
8 #include "base/test/test_simple_task_runner.h"
9 #include "cc/output/begin_frame_args.h"
10 #include "cc/test/begin_frame_args_test.h"
11 #include "testing/gmock/include/gmock/gmock.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13 #include "ui/compositor/compositor.h"
14 #include "ui/compositor/test/context_factories_for_test.h"
15 #include "ui/gfx/geometry/rect.h"
16
17 using testing::Mock;
18 using testing::_;
19
20 namespace ui {
21 namespace {
22
23 class MockCompositorBeginFrameObserver : public CompositorBeginFrameObserver {
24 public:
25 MOCK_METHOD1(OnSendBeginFrame, void(const cc::BeginFrameArgs&));
26 };
27
28 class BeginFrameWithCompositorTest : public testing::Test {
29 public:
30 BeginFrameWithCompositorTest() {}
31 ~BeginFrameWithCompositorTest() override {}
32
33 // Overridden from testing::Test:
34 void SetUp() override {
35 bool enable_pixel_output = false;
36 ui::ContextFactory* context_factory =
37 InitializeContextFactoryForTests(enable_pixel_output);
38 compositor_task_runner_ = new base::TestSimpleTaskRunner();
39 compositor_.reset(new ui::Compositor(gfx::kNullAcceleratedWidget,
40 context_factory,
41 compositor_task_runner_.get()));
42 }
43
44 void TearDown() override {
45 compositor_.reset();
46 TerminateContextFactoryForTests();
47 }
48
49 Compositor* compositor() { return compositor_.get(); }
50
51 cc::BeginFrameArgs missed_begin_frame_args() {
52 return compositor()->MissedBeginFrameArgsForTesting();
53 }
54
55 private:
56 scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner_;
57 scoped_ptr<ui::Compositor> compositor_;
58
59 DISALLOW_COPY_AND_ASSIGN(BeginFrameWithCompositorTest);
60 };
61
62 // Tests whether |missed_begin_frame_args_| is used immediately or not when new
63 // observer is added.
64 TEST_F(BeginFrameWithCompositorTest, AddBeginFrameObserver) {
65 cc::BeginFrameArgs last_args =
66 cc::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE,
67 base::TimeTicks::FromInternalValue(33));
68 cc::BeginFrameArgs new_args =
69 cc::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE,
70 base::TimeTicks::FromInternalValue(55));
71
72 // Simulate to trigger new BeginFrame by using |new_args|.
73 compositor()->SendBeginFramesToChildren(new_args);
74 // |new_args| is stored in |missed_begin_frame_args_| in Compositor for using
75 // later added observers.
76 EXPECT_EQ(new_args.frame_time,
77 missed_begin_frame_args().frame_time);
78
79 // When |missed_begin_frame_args_| is sent, its type is set to MISSED.
80 cc::BeginFrameArgs expected_args(new_args);
81 expected_args.type = cc::BeginFrameArgs::MISSED;
82
83 MockCompositorBeginFrameObserver test_observer;
84 EXPECT_CALL(test_observer, OnSendBeginFrame(expected_args));
85 // When new observer is added, Compositor immediately sends BeginFrame with
86 // |missed_begin_frame_args_| when new observer didn't used it.
87 compositor()->AddBeginFrameObserver(&test_observer, last_args);
88 compositor()->RemoveBeginFrameObserver(&test_observer);
89 Mock::VerifyAndClearExpectations(&test_observer);
90
91 EXPECT_CALL(test_observer, OnSendBeginFrame(_)).Times(0);
92 //test_observer.Reset();
93 // BeginFrame is not sended immediately because new observer already used
94 // |missed_begin_frame_args_|.
95 compositor()->AddBeginFrameObserver(&test_observer, new_args);
96 compositor()->RemoveBeginFrameObserver(&test_observer);
97 }
98
99 } // namespace
100 } // namespace ui
OLDNEW
« content/browser/compositor/delegated_frame_host_unittest.cc ('K') | « ui/compositor/compositor.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698