Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1000463002: Roll Android SDK to API 22 (Closed)

Created:
5 years, 9 months ago by aurimas (slooooooooow)
Modified:
5 years, 9 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Android SDK to API 22 Updated the following: - Android SDK Platform API 22 - Android SDK Tools 24.1.2 - Android SDK Platform-tools 22 - Android SDK Build-tools 22 - Android SDK Sources 22 - Android Support Library 21.0.3 BUG=440601 Committed: https://crrev.com/e2a21a01b60eb329e61499458f51ebae7a0951ad Cr-Commit-Position: refs/heads/master@{#320395}

Patch Set 1 #

Patch Set 2 : deps roll #

Patch Set 3 : Suppress deprecation warnings #

Total comments: 1

Patch Set 4 : Update sdk constant' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/javac.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M build/common.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
aurimas (slooooooooow)
cjhopman: PTAL. I will update DEPS file once https://chromium-review.googlesource.com/#/c/258320/ lands
5 years, 9 months ago (2015-03-10 21:47:33 UTC) #2
cjhopman
lgtm
5 years, 9 months ago (2015-03-11 23:41:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000463002/40001
5 years, 9 months ago (2015-03-12 01:02:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/55576)
5 years, 9 months ago (2015-03-12 03:01:04 UTC) #8
cjhopman
https://codereview.chromium.org/1000463002/diff/40001/build/android/pylib/constants.py File build/android/pylib/constants.py (left): https://codereview.chromium.org/1000463002/diff/40001/build/android/pylib/constants.py#oldcode171 build/android/pylib/constants.py:171: ANDROID_SDK_VERSION = ANDROID_SDK_VERSION_CODES.LOLLIPOP Does this need to be updated?
5 years, 9 months ago (2015-03-12 19:01:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000463002/60001
5 years, 9 months ago (2015-03-12 20:57:38 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-12 22:41:25 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 22:42:46 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e2a21a01b60eb329e61499458f51ebae7a0951ad
Cr-Commit-Position: refs/heads/master@{#320395}

Powered by Google App Engine
This is Rietveld 408576698