Clear need for animation style for forced styleForElement.

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 1582 matching lines @@
     FontBuilder fontBuilder(*this);
     RefPtrWillBeRawPtr<CSSFontSelector> selector = styleEngine().fontSelector();
     fontBuilder.createFontForDocument(selector, documentStyle);
 }
 
 void Document::inheritHtmlAndBodyElementStyles(StyleRecalcChange change)
 {
     ASSERT(inStyleRecalc());
     ASSERT(documentElement());
 
+    bool didRecalcDocumentElement = false;
     RefPtr<LayoutStyle> documentElementStyle = documentElement()->layoutStyle();
-    if (!documentElementStyle || documentElement()->needsStyleRecalc() || change == Force)
+    if (change == Force)
+        documentElement()->clearAnimationStyleChange();

[esprehn, 2015/03/18 11:41:01]

This seems okay as a short term hack, but long term I think we want to refactor
the Element::recalcStyle and Element::recalcOwnStyle so we can compute the style
of the documentElement and the body and then abort and then just call
->layoutStyle() here. Calling into styleForElement() directly like this is the
real bug.

[rune, 2015/03/18 14:53:03]

Acknowledged.

+    if (!documentElementStyle || documentElement()->needsStyleRecalc() || change == Force) {
         documentElementStyle = ensureStyleResolver().styleForElement(documentElement());
+        didRecalcDocumentElement = true;
+    }
 
     WritingMode rootWritingMode = documentElementStyle->writingMode();
     TextDirection rootDirection = documentElementStyle->direction();
 
     HTMLElement* body = this->body();
     RefPtr<LayoutStyle> bodyStyle;
     if (body) {
-        bodyStyle = body->layoutStyle();
-        if (!bodyStyle || body->needsStyleRecalc() || documentElement()->needsStyleRecalc() || change == Force)
+        if (didRecalcDocumentElement)
+            body->clearAnimationStyleChange();
+        else
+            bodyStyle = body->layoutStyle();

[dstockwell, 2015/03/18 11:05:54]

It's confusing to place this in the else branch, is it worth it?

[esprehn, 2015/03/18 11:41:01]

+1

[rune, 2015/03/18 14:53:03]

Done.

+
+        if (!bodyStyle || body->needsStyleRecalc() || didRecalcDocumentElement)

[esprehn, 2015/03/18 11:41:01]

Why do you need to recalc the body if we recalced the document?

[esprehn, 2015/03/18 11:41:37]

document element*

[rune, 2015/03/18 14:53:03]

If documentElement style is changed, it may affect the body style through
inheritance.

             bodyStyle = ensureStyleResolver().styleForElement(body, documentElementStyle.get());
         rootWritingMode = bodyStyle->writingMode();
         rootDirection = bodyStyle->direction();
     }
 
     RefPtr<LayoutStyle> overflowStyle;
     if (Element* element = viewportDefiningElement(documentElementStyle.get())) {
         if (element == body) {
             overflowStyle = bodyStyle;
         } else {
@@ skipping 4094 matching lines @@
 #ifndef NDEBUG
 using namespace blink;
 void showLiveDocumentInstances()
 {
     WeakDocumentSet& set = liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().string().utf8().data());
 }
 #endif