Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1000353004: Remove CompilationInfoWithZone from public API. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove CompilationInfoWithZone from public API. This removes the CompilationInfoWithZone class from the header file because it is more than a pure convenience class and shouldn't be used outside of the compiler at all. R=titzer@chromium.org Committed: https://crrev.com/1fefa31df6040ee4761c7d184f7f421384f05b49 Cr-Commit-Position: refs/heads/master@{#27411}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Further simplification. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -68 lines) Patch
M src/compiler.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/compiler.cc View 1 6 chunks +49 lines, -37 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-23 18:04:44 UTC) #1
titzer
On 2015/03/23 18:04:44, Michael Starzinger wrote: It's a little unfortunate to expand all the uses ...
5 years, 9 months ago (2015-03-24 13:10:38 UTC) #2
titzer
https://codereview.chromium.org/1000353004/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/1000353004/diff/1/src/compiler.cc#newcode87 src/compiler.cc:87: virtual ~CompilationInfoWithZone(); Now you can go ahead and inline ...
5 years, 9 months ago (2015-03-24 13:10:44 UTC) #3
Michael Starzinger
https://codereview.chromium.org/1000353004/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/1000353004/diff/1/src/compiler.cc#newcode87 src/compiler.cc:87: virtual ~CompilationInfoWithZone(); On 2015/03/24 13:10:44, titzer wrote: > Now ...
5 years, 9 months ago (2015-03-24 13:38:16 UTC) #4
titzer
lgtm
5 years, 9 months ago (2015-03-24 13:39:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000353004/20001
5 years, 9 months ago (2015-03-24 14:03:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 14:17:10 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 14:17:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fefa31df6040ee4761c7d184f7f421384f05b49
Cr-Commit-Position: refs/heads/master@{#27411}

Powered by Google App Engine
This is Rietveld 408576698