Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: chrome/browser/interstitials/security_interstitial_page.h

Issue 1000333003: Properly decode IDN in interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Send special commands for text searching, return AssertionResult, other cleanup Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_ 5 #ifndef CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
6 #define CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_ 6 #define CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "content/public/browser/interstitial_page_delegate.h" 9 #include "content/public/browser/interstitial_page_delegate.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
(...skipping 21 matching lines...) Expand all
32 CMD_OPEN_HELP_CENTER = 3, 32 CMD_OPEN_HELP_CENTER = 3,
33 CMD_OPEN_DIAGNOSTIC = 4, 33 CMD_OPEN_DIAGNOSTIC = 4,
34 // Primary button actions 34 // Primary button actions
35 CMD_RELOAD = 5, 35 CMD_RELOAD = 5,
36 CMD_OPEN_DATE_SETTINGS = 6, 36 CMD_OPEN_DATE_SETTINGS = 6,
37 CMD_OPEN_LOGIN = 7, 37 CMD_OPEN_LOGIN = 7,
38 // Safe Browsing Extended Reporting 38 // Safe Browsing Extended Reporting
39 CMD_DO_REPORT = 8, 39 CMD_DO_REPORT = 8,
40 CMD_DONT_REPORT = 9, 40 CMD_DONT_REPORT = 9,
41 CMD_OPEN_REPORTING_PRIVACY = 10, 41 CMD_OPEN_REPORTING_PRIVACY = 10,
42 // Used by tests
43 CMD_TEXT_FOUND = 11,
44 CMD_TEXT_NOT_FOUND = 12
meacer 2015/03/25 01:08:40 How about making these negative values? That way t
estark 2015/03/25 04:23:49 Done.
42 }; 45 };
43 46
44 SecurityInterstitialPage(content::WebContents* web_contents, 47 SecurityInterstitialPage(content::WebContents* web_contents,
45 const GURL& url); 48 const GURL& url);
46 ~SecurityInterstitialPage() override; 49 ~SecurityInterstitialPage() override;
47 50
48 // Creates an interstitial and shows it. 51 // Creates an interstitial and shows it.
49 virtual void Show(); 52 virtual void Show();
50 53
51 // Prevents creating the actual interstitial view for testing. 54 // Prevents creating the actual interstitial view for testing.
(...skipping 23 matching lines...) Expand all
75 // Once shown, |interstitial_page| takes ownership of this 78 // Once shown, |interstitial_page| takes ownership of this
76 // SecurityInterstitialPage instance. 79 // SecurityInterstitialPage instance.
77 content::InterstitialPage* interstitial_page_; 80 content::InterstitialPage* interstitial_page_;
78 // Whether the interstitial should create a view. 81 // Whether the interstitial should create a view.
79 bool create_view_; 82 bool create_view_;
80 83
81 DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialPage); 84 DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialPage);
82 }; 85 };
83 86
84 #endif // CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_ 87 #endif // CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698