Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1000323002: remove duplicate friend declaration (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove duplicate friend declaration Followup to https://codereview.chromium.org/983853002 BUG=455312 Committed: https://crrev.com/46c2139851df34f5d6dc2fa0f2a88aeab4cdb4f6 Cr-Commit-Position: refs/heads/master@{#320421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Mostyn Bramley-Moore
@tdanderson, sky: PTAL at this trivial fix (GCC doesn't seem to like this duplicate line).
5 years, 9 months ago (2015-03-12 23:33:17 UTC) #2
tdanderson
On 2015/03/12 23:33:17, Mostyn Bramley-Moore wrote: > @tdanderson, sky: PTAL at this trivial fix (GCC ...
5 years, 9 months ago (2015-03-12 23:37:10 UTC) #3
sky
LGTM
5 years, 9 months ago (2015-03-12 23:42:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000323002/1
5 years, 9 months ago (2015-03-12 23:43:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 01:21:38 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 01:22:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46c2139851df34f5d6dc2fa0f2a88aeab4cdb4f6
Cr-Commit-Position: refs/heads/master@{#320421}

Powered by Google App Engine
This is Rietveld 408576698